Skip to content

Conversation

Navya-arugonda
Copy link

Summary
Export MISSING_PASSWORD: 'auth/missing-password' via AuthErrorCodes in @firebase/auth.

Why
The SDK can throw auth/missing-password, but it wasn’t exposed via AuthErrorCodes, forcing developers to hardcode the string.

Tests
Adds a Node unit test asserting:
AuthErrorCodes.MISSING_PASSWORD === 'auth/missing-password'.

Fixes
Fixes #9270

CLA
I have signed the Google Contributor License Agreement.

Copy link

changeset-bot bot commented Oct 6, 2025

🦋 Changeset detected

Latest commit: 174bd83

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth Patch
firebase Patch
@firebase/auth-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Navya-arugonda Navya-arugonda requested review from a team as code owners October 6, 2025 17:11
@dlarocque
Copy link
Contributor

dlarocque commented Oct 6, 2025

When we make additions to public APIs, we have to update our reference documentation here on this website: https://firebase.google.com/docs/reference. The documentation hosted on that website is generated from the code in our SDK, and stored in the docs-devsite/ directory.

Since you made a public API addition, you need to generate the documentation for this new API. You can do this by running the yarn docgen:all script and committing the changes. The script will probably make changes to docs-devsite/auth.md in this case.

@Navya-arugonda
Copy link
Author

Thanks for the review!
I’ve moved MISSING_PASSWORD below MISSING_PHONE_NUMBER, reverted the tsconfig.json changes, and removed the unnecessary test file.
Please let me know if any further adjustments are needed.

@Navya-arugonda Navya-arugonda requested a review from a team as a code owner October 6, 2025 18:21
@Navya-arugonda
Copy link
Author

Thanks for the reminder!
I’ve generated and committed the updated docs-devsite/auth.md to include the MISSING_PASSWORD export.

@dlarocque
Copy link
Contributor

Please ignore the CI errors. They're expected to fail on forks.

One last thing though, can you run yarn build in packages/auth? It should generate a common/api-review/auth.api.md file. Can you commit that, too? Sorry I forgot about this on the first pass.

@Navya-arugonda
Copy link
Author

Added the generated auth.api.md via yarn build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"auth/missing-password" not exported via AuthErrorCodes
3 participants