Skip to content

Add support for App Check tokens in logging #9310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: telemetry
Choose a base branch
from
Open

Add support for App Check tokens in logging #9310

wants to merge 3 commits into from

Conversation

mghaznav
Copy link

@mghaznav mghaznav commented Oct 9, 2025

Discussion

Add support for App Check tokens with. If App Check has been initialized in the app, an app check token header will be included with the logging request on client-side.

Testing

Unit tested, manually tested

API Changes

N/A

@mghaznav mghaznav requested review from a team as code owners October 9, 2025 20:58
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 10fa5b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

andrewbrook
andrewbrook reviewed Oct 9, 2025
View reviewed changes
andrewbrook
andrewbrook reviewed Oct 9, 2025
View reviewed changes
andrewbrook
andrewbrook reviewed Oct 9, 2025
View reviewed changes
andrewbrook
andrewbrook reviewed Oct 9, 2025
View reviewed changes
andrewbrook
andrewbrook reviewed Oct 9, 2025
View reviewed changes
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 9, 2025 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/telemetry

    TypeBase (70e7a5f)Merge (ce7d09f)Diff
    browser5.94 kB6.39 kB+445 B (+7.5%)
    main6.69 kB6.51 kB-185 B (-2.8%)
    module5.94 kB6.39 kB+445 B (+7.5%)

  • firebase

    TypeBase (70e7a5f)Merge (ce7d09f)Diff
    firebase-telemetry.js85.9 kB73.5 kB-12.3 kB (-14.4%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/fdxEPiujLa.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 9, 2025 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/telemetry

    • captureError

      Size

      TypeBase (70e7a5f)Merge (ce7d09f)Diff
      size3.57 kB3.84 kB+271 B (+7.6%)
      size-with-ext-deps65.7 kB54.7 kB-11.0 kB (-16.7%)

      Dependency

      TypeBase (70e7a5f)Merge (ce7d09f)Diff
      classes

      FetchTransportEdge
OTLPLogExporterEdge
TelemetryService

      AppCheckProvider
FetchTransport
OTLPLogExporter
TelemetryService

      + AppCheckProvider
+ FetchTransport
+ OTLPLogExporter
- FetchTransportEdge
- OTLPLogExporterEdge

      External Dependency

      ModuleBase (70e7a5f)Merge (ce7d09f)Diff
      @opentelemetry/exporter-logs-otlp-http

      OTLPLogExporter

      - OTLPLogExporter

    • flush

      Size

      TypeBase (70e7a5f)Merge (ce7d09f)Diff
      size2.97 kB3.24 kB+271 B (+9.1%)
      size-with-ext-deps64.4 kB53.4 kB-11.0 kB (-17.0%)

      Dependency

      TypeBase (70e7a5f)Merge (ce7d09f)Diff
      classes

      FetchTransportEdge
OTLPLogExporterEdge
TelemetryService

      AppCheckProvider
FetchTransport
OTLPLogExporter
TelemetryService

      + AppCheckProvider
+ FetchTransport
+ OTLPLogExporter
- FetchTransportEdge
- OTLPLogExporterEdge

      External Dependency

      ModuleBase (70e7a5f)Merge (ce7d09f)Diff
      @opentelemetry/exporter-logs-otlp-http

      OTLPLogExporter

      - OTLPLogExporter

    • getTelemetry

      Size

      TypeBase (70e7a5f)Merge (ce7d09f)Diff
      size2.97 kB3.25 kB+271 B (+9.1%)
      size-with-ext-deps71.5 kB60.5 kB-11.0 kB (-15.3%)

      Dependency

      TypeBase (70e7a5f)Merge (ce7d09f)Diff
      classes

      FetchTransportEdge
OTLPLogExporterEdge
TelemetryService

      AppCheckProvider
FetchTransport
OTLPLogExporter
TelemetryService

      + AppCheckProvider
+ FetchTransport
+ OTLPLogExporter
- FetchTransportEdge
- OTLPLogExporterEdge

      External Dependency

      ModuleBase (70e7a5f)Merge (ce7d09f)Diff
      @opentelemetry/exporter-logs-otlp-http

      OTLPLogExporter

      - OTLPLogExporter

    • nextOnRequestError

      Size

      TypeBase (70e7a5f)Merge (ce7d09f)Diff
      size3.92 kB4.19 kB+271 B (+6.9%)
      size-with-ext-deps73.1 kB62.1 kB-11.0 kB (-15.0%)

      Dependency

      TypeBase (70e7a5f)Merge (ce7d09f)Diff
      classes

      FetchTransportEdge
OTLPLogExporterEdge
TelemetryService

      AppCheckProvider
FetchTransport
OTLPLogExporter
TelemetryService

      + AppCheckProvider
+ FetchTransport
+ OTLPLogExporter
- FetchTransportEdge
- OTLPLogExporterEdge

      External Dependency

      ModuleBase (70e7a5f)Merge (ce7d09f)Diff
      @opentelemetry/exporter-logs-otlp-http

      OTLPLogExporter

      - OTLPLogExporter

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/UD4zcwgOwx.html

hsubox76
hsubox76 reviewed Oct 10, 2025
View reviewed changes
yarn.lock
integrity sha512-aqD2Q0144Z+/RqG52NeHEkZauTAUWJO8c6yTftGJKO3Tja5tUgIfmIl6kExvhtxSDP7fXB6DvzkfMpCd/F3G+Q==

"string-width-cjs@npm:string-width@^4.2.0":
"string-width-cjs@npm:string-width@^4.2.0", "string-width@^1.0.2 || 2 || 3 || 4", string-width@^4.0.0, string-width@^4.1.0, string-width@^4.2.0, string-width@^4.2.2, string-width@^4.2.3:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why yarn.lock would change? I don't see any changes to package.json. Did you delete and regenerate yarn.lock?

packages/telemetry/src/logging/fetch-transport.ts
/** @internal */
export interface FetchTransportParameters {
url: string;
headers: () => Record<string, string>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to use Headers()? Just a suggestion https://developer.mozilla.org/en-US/docs/Web/API/Headers/Headers Doesn't offer any real advantages other than clearer typing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hsubox76 hsubox76 hsubox76 left review comments

@andrewbrook andrewbrook andrewbrook approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mghaznav @google-oss-bot @hsubox76 @andrewbrook