Skip to content

Conversation

MarkDuckworth
Copy link
Contributor

feat/pipeline to the console branch

NhienLam and others added 30 commits February 4, 2025 14:18
…namicLinkDomain (#8738)

* Add linkDomain field to ActionCodeSettings (#8428)

* Add linkDomain field to ActionCodeSettings

* Update API reports

* Update error message for ERROR_INVALID_HOSTING_LINK_DOMAIN to include that default hosting domains cannot be used.

* Use constants for test values

---------

Co-authored-by: NhienLam <NhienLam@users.noreply.github.com>

* FDL Deprecation & Hosting link Integration Test (#8603)

* Implement Integration test for passwordless email sign-in via firebase-hosting links.

* Add license to new test file created' did not match any files

* Remove unwanted _

* Add support for setting custom hosting link domain in test app (#8614)

* Add afterEach method and apply formatting to the hosting links integration test (#8615)

* Mark ActionCodeSettings.dynamicLinkDomain as deprecated

* Add changeset

* Update API reports

* Address review comments

* Fix changeset

* Update refdocs and address review comments

* Update deprecated comment

* Add FDL deprecation FAQ link

* Fix linkDomain link in refdocs

---------

Co-authored-by: NhienLam <NhienLam@users.noreply.github.com>
Co-authored-by: mansisampat <sammansi@google.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Update `connectFirestoreEmulator` to support its invocation more than once. If the Firestore instance is already in use, and `connectFirestoreEmulator` is invoked with the same configuration, then the invocation will now succeed instead of assert.

The implementation takes the Data Connect implementation as inspiration. Data Connect stores the parameters passed to `connectDataConnectEmulator` on the instance of Data Connect itself, so that they can be quickly checked to see if subsequent invocations match. This PR implements a similar storage and compare process with the optional `emulatorOptions` parameter (host and port are already stored).

This PR unlocks support for SSR frameworks which render the page numerous times with the same instances of Firestore. Before this PR customers were required to guard against calling `connectFirestoreEmulator` in their SSR logic, which added to code complexity. Now the Firebase SDK does that guarding logic so that our users' apps don't have to.
Update the `connectDatabaseEmulator` function to support its invocation more than once. If the Database instance is already in use, and `connectDatabaseEmulator` is invoked with the same configuration, then the invocation will now succeed instead of assert.

This unlocks support for web frameworks which may render the page numerous times with the same instances of RTDB. Before this PR customers needed to add extra code to guard against calling `connectDatabaseEmulator` in their SSR logic. Now we do that guarding logic on their behalf which should simplify our customer's apps.

Fixes #6824.
SSR related improvements for RC client SDK.

* Exposes an initialFetchResponse arg that pre-hydrates the client SDK state
* Adds an argument that allows setting an alternate template ID to fetch from
* Splits storage impls into a simple in-memory version that can be run in SSR contexts
* Adds some basic tests for the API functions, which were previously untested
Update the `connectAuthEmulator` function to support its invocation more than once. If the Auth instance is already in use, and `connectAuthEmulator` is invoked with the same configuration, then the invocation will now succeed instead of assert.

This unlocks support for web frameworks which may render the page numerous times with the same instances of auth. Before this PR customers needed to add extra code to guard against calling `connectAuthEmulator` in their SSR logic. Now we do that guarding logic on their behalf which should simplify our customer's apps.

Fixes #6824.
* first batch

* @rollup/plugin-node-resolve 13 -> 16
* Filter empty text parts when streaming

* Add changeset

* Remove unused filterEmptyTextParts()

* Move logic into a function

* final

* dont throw if mock response file isn't found

* update responses version to 6

* Only ignore empty text parts in the aggregated response.

* review fixes

* Throw in `aggregateResponses` if `newPart` has no properties
* Change (BETA) annotation to (Public Preview)

* format

* Minor bump
* Create Node CJS and ESM bundles

* Add changeset

* Run formatter

* register version with node
* Fix vectorvalue docs

* Use @link vector

* Fix vector link with code tag
* Re-enable redirect tests

* Fix lint
* WIP

* Introduce VertexAIModel base class, add documentation, and respond to other comments

* Generate devsite docs

* revert dataconnect change

* formatting

* WIP

* Introduce VertexAIModel base class, add documentation, and respond to other comments

* Generate devsite docs

* revert dataconnect change

* formatting

* Fix ImagenRequestConfig comment

* Improve tests

* Formatting

* Add ImagenGenerationResponse

* Formatting

* Update to match API changes

* fixes

* format

* Update API reports

* add changeset

* update

* format

* Update API reports

* remove public docs

* Nest imageFormat in outputOptions

* remove unecessary console.log

* Log warning if compressionQuality outside of range

* format

* Imagen Documentation (#8776)

* Revert "remove public docs"

This reverts commit f095563.

* update docs

* update docs

* format

* minor fixes

* format

* mark all APIs beta instead of public

* review fixes

* format

* Replace (BETA) with (Public Preview) in docs

* fix links

* another pass

* format

* review fixes

* Cleanup

* update changeset

---------

Co-authored-by: dlarocque <dlarocque@users.noreply.github.com>
* Add support for token-based usage metrics.

Token measurement is broken down by modaliy, with separate counters for image, audio, etc.

Tests are in version 6.*, so this change also includes bumping update_responses.sh

* Use right name for unspecified enum

* Update API reports

* Make promptTokensDetails an array

* Update API reports

* Add missing documentation

* Add changeset entry

* Fix formatting errors

* Update API reports

* Add missing refdoc

* Update API reports

* Use correct formatting for Modality documentation.

* Update API reports

* Update docs

* Update packages/vertexai/src/types/enums.ts

Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>

* Update md files

* Revert changes to api-extractor.json

---------

Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>
dlarocque and others added 16 commits September 25, 2025 10:53
For JS SDK release v12.4.0

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Skip pipeline tests in lite, for now

* update bundle definitions for size report

* Fix size testing for pipelines bundles

* fixed typings

* Fixed package paths

* Fix integration tests that run on the built packages
…into markduckworth/feat-pipelines-to-console
* Revert emulator overlay

* Re-add emitEmulatorWarning that was not part of the emulator overlay

* formatting

* remove other references to updateEmulatorBanner
Copy link

changeset-bot bot commented Oct 10, 2025

⚠️ No Changeset found

Latest commit: c134f26

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 10, 2025

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (8e69956)Merge (6f841b9)Diff
    browser391 kB393 kB+1.10 kB (+0.3%)
    main611 kB634 kB+23.4 kB (+3.8%)
    module391 kB393 kB+1.10 kB (+0.3%)
    react-native392 kB393 kB+1.13 kB (+0.3%)
  • @firebase/firestore-lite

    TypeBase (8e69956)Merge (6f841b9)Diff
    browser115 kB118 kB+2.45 kB (+2.1%)
    main158 kB169 kB+10.3 kB (+6.5%)
    module115 kB118 kB+2.45 kB (+2.1%)
    react-native115 kB118 kB+2.44 kB (+2.1%)
  • @firebase/firestore-lite-pipelines

    TypeBase (8e69956)Merge (6f841b9)Diff
    browser?108 kB? (?)
    main?207 kB? (?)
    module?108 kB? (?)
    react-native?108 kB? (?)
  • @firebase/firestore-pipelines

    TypeBase (8e69956)Merge (6f841b9)Diff
    browser?203 kB? (?)
    main?630 kB? (?)
    module?203 kB? (?)
    react-native?203 kB? (?)
  • bundle

    18 size changes

    TypeBase (8e69956)Merge (6f841b9)Diff
    firestore (CSI Auto Indexing Disable and Delete)282 kB282 kB+248 B (+0.1%)
    firestore (CSI Auto Indexing Enable)282 kB282 kB+248 B (+0.1%)
    firestore (Persistence)314 kB314 kB+228 B (+0.1%)
    firestore (Pipeline Query with lt filter (execute))?240 kB? (?)
    firestore (Pipeline Query with lt filter (useFirestorePipelines))?166 kB? (?)
    firestore (Pipeline Query with lt plus and function)?166 kB? (?)
    firestore (Query Cursors)253 kB254 kB+761 B (+0.3%)
    firestore (Query)250 kB251 kB+775 B (+0.3%)
    firestore (Read data once)240 kB240 kB+124 B (+0.1%)
    firestore (Read Write w Persistence)333 kB334 kB+625 B (+0.2%)
    firestore (Realtime updates)241 kB241 kB+133 B (+0.1%)
    firestore (Transaction)219 kB220 kB+687 B (+0.3%)
    firestore (Write data)220 kB221 kB+591 B (+0.3%)
    firestore-lite (Query Cursors)105 kB108 kB+2.19 kB (+2.1%)
    firestore-lite (Query)102 kB104 kB+2.05 kB (+2.0%)
    firestore-lite (Read data once)77.3 kB78.5 kB+1.21 kB (+1.6%)
    firestore-lite (Transaction)103 kB105 kB+2.00 kB (+2.0%)
    firestore-lite (Write data)86.8 kB88.5 kB+1.79 kB (+2.1%)

  • firebase

    TypeBase (8e69956)Merge (6f841b9)Diff
    firebase-compat.js805 kB806 kB+773 B (+0.1%)
    firebase-firestore-compat.js343 kB344 kB+771 B (+0.2%)
    firebase-firestore-lite.js134 kB135 kB+523 B (+0.4%)
    firebase-firestore-pipelines.js?258 kB? (?)
    firebase-firestore.js449 kB450 kB+673 B (+0.1%)
    pipelines.js?120 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/lD2DxEO0H9.html

…firebase/firebase-js-sdk into markduckworth/feat-pipelines-to-console
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 10, 2025

Size Analysis Report 1

This report is too large (1,065,864 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/JTy1sCHvP6.html

@MarkDuckworth MarkDuckworth marked this pull request as ready for review October 10, 2025 18:44
@MarkDuckworth MarkDuckworth requested review from a team as code owners October 10, 2025 18:44
@MarkDuckworth MarkDuckworth merged commit 90fed2f into console Oct 10, 2025
43 of 48 checks passed
@MarkDuckworth MarkDuckworth deleted the markduckworth/feat-pipelines-to-console branch October 10, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.