Skip to content
This repository was archived by the owner on Mar 17, 2025. It is now read-only.

Conversation

cbraynor
Copy link
Contributor

@cbraynor cbraynor commented Jan 5, 2017

Same as #99 so travis will run

The `retries` field of the specs was missing from the suggested rules. Together with `$other": {  ".validate": false }` this meant that the retries parameter could not be used in specs.
@cbraynor cbraynor self-assigned this Jan 5, 2017
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

1 similar comment
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@coveralls
Copy link

coveralls commented Jan 5, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 5041dee on Caerbannog-patch-1 into 7df13b6 on master.

@cbraynor cbraynor merged commit fbaad3d into master Jan 5, 2017
@cbraynor cbraynor deleted the Caerbannog-patch-1 branch January 5, 2017 16:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants