Skip to content
This repository was archived by the owner on Mar 17, 2025. It is now read-only.

Conversation

rafalsobota
Copy link
Contributor

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@rafalsobota
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

src/queue.js Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check out lodash's _.has() method here to simplify the logic

@cbraynor
Copy link
Contributor

Thanks for the PR. I like the idea of being able to specify these values and how this is backwards compatible, but the JSDoc comments, README documentation, and tests all need updating before I can consider merging this PR.

Also check out my couple of nit-pick comments.

@rafalsobota
Copy link
Contributor Author

Thanks for the response. Something else should be improved?

@cbraynor cbraynor mentioned this pull request Mar 21, 2016
@cbraynor cbraynor closed this in #53 Mar 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants