This repository was archived by the owner on Mar 17, 2025. It is now read-only.
Allowing a task to pass a _new_state #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 22, 2016 17:18
…ides the task spec's finished_state
src/lib/queue_worker.js
Outdated
| newTask._progress = 100; | ||
| newTask._error_details = null; | ||
| return newTask; | ||
| if (outputTask._new_state === false) { |
There was a problem hiding this comment.
Let's put a comment here explaining what exactly this does.
There was a problem hiding this comment.
Also let's move this conditional up with the self.finishedState null check.
| outputTask._state = _.get(outputTask, '_new_state'); | ||
| delete outputTask._new_state; | ||
| if (!_.isNull(outputTask._state) && !_.isString(outputTask._state)) { | ||
| if (_.isNull(self.finishedState) || outputTask._state === false) { |
There was a problem hiding this comment.
Can you add a comment about the explicit false API just because it's not necessarily intuitive.
|
LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing a task to pass a
_new_statein the object passed toresolvethat overrides the task spec'sfinished_state