Skip to content

Commit

Permalink
temporarily remove extensions deploy from functions (#7600)
Browse files Browse the repository at this point in the history
* temporarily remove extensions deploy from functions
  • Loading branch information
ifielker authored Aug 27, 2024
1 parent 8ee858b commit dee2c89
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 9 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
- Released Firestore Emulator v 1.19.8 which adds support for `FindNearest.distanceResultField` and `FindNearest.distanceThreshold` parameters.
- Temporarily removing extensions from functions deploy because it was causing unexpected extension deletions.
18 changes: 9 additions & 9 deletions src/deploy/functions/prepare.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ import { generateServiceIdentity } from "../../gcp/serviceusage";
import { applyBackendHashToBackends } from "./cache/applyHash";
import { allEndpoints, Backend } from "./backend";
import { assertExhaustive } from "../../functional";
import { prepareDynamicExtensions } from "../extensions/prepare";
import { Context as ExtContext, Payload as ExtPayload } from "../extensions/args";
// import { prepareDynamicExtensions } from "../extensions/prepare";
// import { Context as ExtContext, Payload as ExtPayload } from "../extensions/args";

export const EVENTARC_SOURCE_ENV = "EVENTARC_CLOUD_EVENT_SOURCE";

Expand Down Expand Up @@ -101,13 +101,13 @@ export async function prepare(
);

// == Phase 1.5 Prepare extensions found in codebases if any
if (Object.values(wantBuilds).some((b) => b.extensions)) {
const extContext: ExtContext = {};
const extPayload: ExtPayload = {};
await prepareDynamicExtensions(extContext, options, extPayload, wantBuilds);
context.extensions = extContext;
payload.extensions = extPayload;
}
// if (Object.values(wantBuilds).some((b) => b.extensions)) {
// const extContext: ExtContext = {};
// const extPayload: ExtPayload = {};
// await prepareDynamicExtensions(extContext, options, extPayload, wantBuilds);
// context.extensions = extContext;
// payload.extensions = extPayload;
// }

// == Phase 2. Resolve build to backend.
const codebaseUsesEnvs: string[] = [];
Expand Down

0 comments on commit dee2c89

Please sign in to comment.