Transition to cross-env-shell for lifecyle hooks #1068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a change related to the standalone installer (firepit) initiative. In Firepit we use intermediary node processes which reroute core node/npm/sh back into the standalone installer. This multi-level process stacking results in loss of environmental variables if they're not passed via
cross-env-shell.Changing to
cross-env-shellrequires escaping the quotes in the command to ensure it is passed properly.I do not believe this will impact any developers and should add robustness to the cross-env invocation.
Scenarios Tested
Typescript lifecycle hooks on Windows & Linux with spaces in path and without.