Skip to content

Convert RulesDeploy.js into TypeScript #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 11, 2019
Merged

Convert RulesDeploy.js into TypeScript #1189

merged 4 commits into from
Apr 11, 2019

Conversation

ryanpbrewster
Copy link
Contributor

I tried to keep this as unobtrusive as possible. There's a lot of line-noise involved in converting JS to TypeScript just due to eslint, so my preference would be to merge this as-is and then "upgrade" the typescript to be more idiomatic in a separate PR, where the style changes can be inspected alone.

@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label Apr 11, 2019
@ryanpbrewster ryanpbrewster requested a review from bkendall April 11, 2019 03:41
@ryanpbrewster ryanpbrewster mentioned this pull request Apr 11, 2019
Merged
@coveralls
Copy link

Coverage Status

Coverage remained the same at 60.188% when pulling b730144 on rpb/tsify-rulesdeploy into 25a5d44 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 60.188% when pulling b730144 on rpb/tsify-rulesdeploy into 25a5d44 on master.

@coveralls
Copy link

coveralls commented Apr 11, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 61.71% when pulling 8af355c on rpb/tsify-rulesdeploy into bdf7a1b on master.

bkendall
bkendall requested changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@bkendall bkendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's definitely more to clean up, but I think these comments are necessary evil in initially converting a file - shouldn't have too much of an impact, I think.

bkendall
bkendall approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@bkendall bkendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine assuming all testing passes :) Thanks

@ryanpbrewster ryanpbrewster merged commit a3bac4c into master Apr 11, 2019
@ryanpbrewster ryanpbrewster deleted the rpb/tsify-rulesdeploy branch April 11, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkendall bkendall bkendall approved these changes

Assignees

@bkendall bkendall

Labels

cla: yes Manual indication that this has passed CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ryanpbrewster @coveralls @bkendall @googlebot