Skip to content

Disable functions emulator advanced features when 'served' #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2019
Merged

Disable functions emulator advanced features when 'served' #1250

merged 2 commits into from
May 7, 2019

Conversation

samtstern
Copy link
Contributor

@AbeHaskins had this idea, that way some of the really cool things the new emulator does won't freak people out who have been using serve with Functions for a while.

@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label May 7, 2019
@samtstern samtstern requested a review from abeisgoat May 7, 2019 19:20
@coveralls
Copy link

coveralls commented May 7, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 60.588% when pulling 0fd8fd0 on ss-disable-emu-features into 1dfa342 on master.

@abeisgoat abeisgoat merged commit c8fbb77 into master May 7, 2019
@samtstern samtstern deleted the ss-disable-emu-features branch June 20, 2019 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@abeisgoat abeisgoat abeisgoat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes Manual indication that this has passed CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@samtstern @coveralls @abeisgoat @googlebot