Skip to content

Conversation

abeisgoat
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label May 7, 2019
@coveralls
Copy link

coveralls commented May 7, 2019

Coverage Status

Coverage increased (+0.01%) to 60.604% when pulling 82e952f on ah-emulator-suite into 1befc99 on master.

@abeisgoat abeisgoat requested a review from samtstern May 8, 2019 02:44
@samtstern
Copy link
Contributor

I tried to run this on the firebaseopensourcerepo which has a PubSub function and got:

⚠  Error: process.env.GCLOUD_PROJECT is not set.
    at TopicBuilder (/Users/samstern/Projects/firebaseopensource.com/functions/node_modules/firebase-functions/lib/providers/pubsub.js:43:19)
    at Function.get (/Users/samstern/Projects/firebaseopensource.com/functions/node_modules/firebase-functions/lib/cloud-functions.js:156:17)
    at extractTriggers (/Users/samstern/Projects/firebase-tools/lib/extractTriggers.js:7:54)
    at /Users/samstern/Projects/firebase-tools/lib/emulator/functionsEmulatorRuntime.js:481:38
    at Generator.next (<anonymous>)
    at /Users/samstern/Projects/firebase-tools/lib/emulator/functionsEmulatorRuntime.js:7:71
    at new Promise (<anonymous>)
    at __awaiter (/Users/samstern/Projects/firebase-tools/lib/emulator/functionsEmulatorRuntime.js:3:12)
    at main (/Users/samstern/Projects/firebase-tools/lib/emulator/functionsEmulatorRuntime.js:441:12)
    at Object.<anonymous> (/Users/samstern/Projects/firebase-tools/lib/emulator/functionsEmulatorRuntime.js:527:5)
⚠  Your function was killed because it raised an unhandled error.

I think this has to do with the env changes.

Copy link
Contributor

@samtstern samtstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about crash.

@samtstern
Copy link
Contributor

Abes fixed all my local crashes.

@abeisgoat abeisgoat merged commit 2bc4248 into master May 8, 2019
matheo added a commit to matheo/firebase-tools that referenced this pull request Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants