-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Firestore emulator live update on rules file changes #1358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What is the behavior you'd expect if you have a syntax error in your rules? |
@ryanpbrewster I would expect the emulator to reject the ruleset with a 4xx error ... what does it actually do? |
It does indeed fail, and as a result does not update the rules. You end up in a situation where you're editing your rules and the edits aren't taking effect. Unless you look at the emulator suite logging (often in the background or in some other terminal) you won't be able to figure out why. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Much better!
The Travis build passed but I think the webhook back to GitHub must have been dropped: So I am going to merge this. |
Watches the file specified in
firebase.json
for changes and updates the rules in the emulator.Successful Change

Unsuccessful Change

I styled the error printing based on what the TypeScript compiler does in "watch" mode.