Choose a WebChannel port #1578
Merged
Choose a WebChannel port #1578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tempted to bail on this and put effort into serving webchannel traffic from the same port as gRPC + REST traffic |
samtstern
commented
Aug 1, 2019
|
@ryanpbrewster happy to bail on this if you think that is achievable! But we need one or the other for the FireConf codelab. |
|
@ryanpbrewster now that #1584 is submitted this is simplified and ready for review. |
ryanpbrewster
approved these changes
Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When starting the Firestore emulator, scan 10 ports for a place to serve WebChannel traffic.
This should probably not ship until the flag is renamed to
webchannel_portwhich will make the code cleaner and life easier 🏄♂️ 😎 🌞Scenarios Tested
Tested with both available and unavailable ports.
Sample Commands
N/A