Fixes firepit-builder pipeline on Windows #1902
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, welcome to PR, I'll bring around a round of waters to get you started.
Today's special is a series of artisan fixes from free-range developers.
First, we update the
firepit-builder
Dockerfile to usenode@12
, which has the decadent side-effect of shiftingfirepit
builds to usingnode@12
as well. This is surely to delight your palette while keeping you hungry for more.We're also thrilled to offer a flight of changes to
firepit-builder/pipeline.js
which compliment each other and come together into what we're calling Maintenant, le script de pipeline fonctionne sur Windows or (in English) "Now the pipeline script works on Windows." The largest issue was the config templating system used find/replace for paths, which did not handle Window's\
paths, as some of our patrons noticed that\
is an escape character in JSON, which produced a very conflicting flavor for some.We're also thrilled to say, in the back kitchen, we've introduced the fame chef
shx
who will be helping us ensure that ourchmod
calls are cross-platform. Of course, he won't influence our primetimepackage.json
menu and will stay as a core part of thefirepit-builder
section.Aside from helping our Yelp reviews, we also believe that these updates should mend the issues raised in #1796 and hopefully stabilize the Windows builds by no longer corrupting the
config
files generated from our templates.Thanks again for joining us tonight, I'll check back in a moment to get your orders.