Support multi-resource storage rules deployment. #476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenzlong
suggested changes
Sep 28, 2017
| _.forEach(rulesMap, function(rules, filename) { | ||
| utils.logBullet(chalk.cyan('storage:') + ' uploading rules ' + chalk.bold(filename) + '...'); | ||
| promises.push(gcp.rules.createRuleset(options.project, rules.files).then(function(rulesetName) { | ||
| rules.ruleset = rulesetName; |
There was a problem hiding this comment.
What is the purpose of this line?
There was a problem hiding this comment.
It persists the created ruleset name in the context so the release phase can access it when performing a release. See https://github.com/firebase/firebase-tools/pull/476/files#diff-636795e647db388748a86f13457eb5ebR22
laurenzlong
approved these changes
Sep 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.