Skip to content

Conversation

lfkellogg
Copy link
Contributor

@lfkellogg lfkellogg commented Jan 30, 2024

Description

Adding --test-devices and related flags to appdistribution:distribute action. This will trigger the new Automated Tester feature.

Scenarios Tested

  • Kick off tests for a release
  • Kick off tests async
  • Kick off tests with username/password
  • Kick off tests with username/password and resource IDs
  • Kick off tests with username but not password (error case)
  • Kick off tests with username resource but not password resource (error case)
  • Kick off tests with username/password resource but not username/password (error case)

Sample Commands

firebase appdistribution:distribute --app <app id> <path> --test-devices <devices>
firebase appdistribution:distribute --app <app id> <path> --test-devices <devices> --test-async
firebase appdistribution:distribute --app <app id> <path> --test-devices <devices> --test-username <user> --test-password <password>
firebase appdistribution:distribute --app <app id> <path> --test-devices <devices> --test-username <user> --test-password <password> --test-username-resource <resource id> --test-password-resource <resource id>

@lfkellogg lfkellogg marked this pull request as draft January 31, 2024 14:21
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

❌ Patch coverage is 92.40506% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.31%. Comparing base (8e388c1) to head (c1f6d9e).
⚠️ Report is 1301 commits behind head on master.

Files with missing lines Patch % Lines
src/appdistribution/options-parser-util.ts 89.13% 3 Missing and 2 partials ⚠️
src/appdistribution/client.ts 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6730      +/-   ##
==========================================
+ Coverage   54.25%   54.31%   +0.05%     
==========================================
  Files         347      349       +2     
  Lines       24197    24283      +86     
  Branches     5005     5021      +16     
==========================================
+ Hits        13129    13190      +61     
- Misses       9866     9888      +22     
- Partials     1202     1205       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lfkellogg lfkellogg requested a review from rebehe January 31, 2024 15:46
@lfkellogg lfkellogg marked this pull request as ready for review January 31, 2024 15:47
@lfkellogg lfkellogg force-pushed the appdistro-tests branch 2 times, most recently from e6d5ee1 to cd4c845 Compare January 31, 2024 15:57
@joehan joehan self-requested a review January 31, 2024 16:33
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code mostly looks good, with a few small style fixes suggested. However, this change needs an approved API proposal since it changes that public API of the CLI. I have some concerns about the API for this command that would be better discussed there. I couldn't find one at go/firebase-api-tracker - could you link one if I missed it, or start one up?

@lfkellogg lfkellogg force-pushed the appdistro-tests branch 2 times, most recently from 2df6e0b to 9469c64 Compare February 6, 2024 15:09
@lfkellogg lfkellogg merged commit c95059d into master Feb 6, 2024
@lfkellogg lfkellogg deleted the appdistro-tests branch February 6, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants