Run vscode tests in the CI #7001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrousselGit
commented
May 21, 2024
hlshen
approved these changes
May 28, 2024
joehan
approved these changes
May 29, 2024
.github/workflows/node-test.yml
Outdated
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| cache: npm | ||
| cache-dependency-path: npm-shrinkwrap.json |
There was a problem hiding this comment.
Should this be firebase-vscode/[package-lock.json instead (or in addition)? I assume we want to cache the vscode deps here.
| cache-dependency-path: npm-shrinkwrap.json | ||
|
|
||
| - run: npm i -g npm@9.5 | ||
| - run: npm ci |
There was a problem hiding this comment.
Double checking - if you remove this line, do the tests still pass?
There was a problem hiding this comment.
I doubt it. We have to run npm i in both the root and the vscode folder.
The npm i -g above doesn't count as it only updates the npm version and nothing else.
rrousselGit
commented
May 30, 2024
rrousselGit
commented
May 30, 2024
rrousselGit
commented
May 30, 2024
rrousselGit
commented
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scenarios Tested
Sample Commands