Fixing init dataconnect on some empty schema cases #8051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maneesht
approved these changes
Dec 11, 2024
| } | ||
| } else { | ||
| // Even if the schema is empty, lets give them an emty .gql file to get started. | ||
| fs.ensureFileSync(join(dir, "schema", "schema.gql")); |
There was a problem hiding this comment.
Do you think it's worth also filling in that schema with the commented out schema? I could go either way
There was a problem hiding this comment.
This is a little safer in case they already had a schema.gql file - ensure won't overwrite it
maneesht
reviewed
Dec 11, 2024
| expectedSource: string; | ||
| expectedFiles: string[]; | ||
| expectCSQLProvisioning: boolean; | ||
| expectEnsureSchemaGQL: boolean; |
There was a problem hiding this comment.
No change required, but this could've been optional, and you wouldn't have to change any of the existing test-cases
Co-authored-by: Maneesh Tewani <maneesht@users.noreply.github.com>
inlined
pushed a commit
that referenced
this pull request
Dec 11, 2024
* Fixing init dataconnect on some empty schema cases * Ensure schema.gql, not just dir, and add test * Update src/init/features/dataconnect/index.ts Co-authored-by: Maneesh Tewani <maneesht@users.noreply.github.com> --------- Co-authored-by: Maneesh Tewani <maneesht@users.noreply.github.com>
inlined
pushed a commit
that referenced
this pull request
Dec 11, 2024
* Fixing init dataconnect on some empty schema cases * Ensure schema.gql, not just dir, and add test * Update src/init/features/dataconnect/index.ts Co-authored-by: Maneesh Tewani <maneesht@users.noreply.github.com> --------- Co-authored-by: Maneesh Tewani <maneesht@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where
firebase init dataconnectwould error out when importing services that have schemas with no GQL files. Thanks @maneesht for debugging this with me!