Skip to content

Conversation

pr-Mais
Copy link
Member

@pr-Mais pr-Mais commented Jan 14, 2025

Description

Scenarios Tested

Sample Commands

@pr-Mais pr-Mais marked this pull request as ready for review January 30, 2025 17:04
@hlshen hlshen self-requested a review January 30, 2025 19:27

private getHighlightJsThemeUrl(): string {
// Check if the current VS Code theme is dark or light
const isDarkTheme =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verifying, does this cover all of the VSCode dark themes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was missing the HighContrast one

".",
)[0] + "-generated";

const viewUri = vscode.Uri.parse(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a comment explaining this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it better now?


async collectGqlFiles(type: "schema" | "operation"): Promise<string[]> {
try {
const workspaceFolders = vscode.workspace.workspaceFolders;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should reference the selected service specifically by using ResolveDataConnectConfigs -> getConnectorDirs() and getSchemaDirs().

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also ResolveDataConnectConfigs.findEnclosingServiceForPath() to get the specific service first. Every gemini call should be based around a single service

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the entrypoint from the sidebar doesn't have a file reference, you can ignore that requirement. But for codelense please determine the service through the clicked file

</style>
<script src=" https://cdnjs.cloudflare.com/ajax/libs/highlight.js/11.8.0/highlight.min.js">
</script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/highlight.js/11.8.0/languages/graphql.min.js"></script>

Check warning

Code scanning / CodeQL

Inclusion of functionality from an untrusted source Medium

Script loaded from content delivery network with no integrity check.
@pr-Mais pr-Mais requested a review from hlshen January 31, 2025 11:20
@hlshen hlshen changed the base branch from master to launch.gif February 10, 2025 15:40
@hlshen hlshen merged commit f23e749 into launch.gif Feb 10, 2025
13 of 21 checks passed
hlshen added a commit that referenced this pull request May 14, 2025
* feat: GQL AI assistant

* feat: init gemini assist controller

* (wip): use custom editor

* feat: view column & copy button

* feat: inserting code

* feat: append instead of replace

* chore: update lock

* fix: get back css-loader

* addressing comments

* feat: use data connect configs

* fix: html content setting

---------

Co-authored-by: Harold Shen <hlshen@google.com>
hlshen added a commit that referenced this pull request May 16, 2025
* feat: GQL AI assistant (#8116)

* feat: GQL AI assistant

* feat: init gemini assist controller

* (wip): use custom editor

* feat: view column & copy button

* feat: inserting code

* feat: append instead of replace

* chore: update lock

* fix: get back css-loader

* addressing comments

* feat: use data connect configs

* fix: html content setting

---------

Co-authored-by: Harold Shen <hlshen@google.com>

* temp initial types and service done

* Fix service file

* remove debugging logs

* successful calls

* Add new line

* temp working gemini tool

* working demo

* change id to dataconnect

* change cloudAiCompanion to prod

* Add backend for CloudAICompanion calls

* controller code

* GCA controls implemented

* Update webview and clean code

* revert unecessary changes

* package-lock

* cleanup

* more cleanup

* update test to build extensionDependency

* add small fix to support gca download delay

* Fix error flow

* fix lint

* change command to pretest

* fix imports

* fix verison of code-server

* add changelog

* format changelog

---------

Co-authored-by: Mais Alheraki <mais.alheraki@gmail.com>
TrCaM pushed a commit that referenced this pull request May 26, 2025
* feat: GQL AI assistant (#8116)

* feat: GQL AI assistant

* feat: init gemini assist controller

* (wip): use custom editor

* feat: view column & copy button

* feat: inserting code

* feat: append instead of replace

* chore: update lock

* fix: get back css-loader

* addressing comments

* feat: use data connect configs

* fix: html content setting

---------

Co-authored-by: Harold Shen <hlshen@google.com>

* temp initial types and service done

* Fix service file

* remove debugging logs

* successful calls

* Add new line

* temp working gemini tool

* working demo

* change id to dataconnect

* change cloudAiCompanion to prod

* Add backend for CloudAICompanion calls

* controller code

* GCA controls implemented

* Update webview and clean code

* revert unecessary changes

* package-lock

* cleanup

* more cleanup

* update test to build extensionDependency

* add small fix to support gca download delay

* Fix error flow

* fix lint

* change command to pretest

* fix imports

* fix verison of code-server

* add changelog

* format changelog

---------

Co-authored-by: Mais Alheraki <mais.alheraki@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants