-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add backend for CloudAICompanion calls #8551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f64f840
to
84e57f2
Compare
@@ -0,0 +1,100 @@ | |||
import { ClientResponse, Client } from "../apiv2"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't. Unfortunately had this code sitting around for awhile. Do you mind if we push the merge to post I/O?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to unblock you in short term~
Though let's clean them up soon. It's fine to check-in unused experimental codes to master~
Feature branch is useful when we want to hide a launch from public in the FirebasePrivate
repos. If it's already public, don't think there are much values keeping it un-merged for long.
|
||
/** Start Gemini client types */ | ||
|
||
export interface CallCloudAiCompanionRequest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's separate the FDC API's types and Cloud AI Companion (TAF)'s types.
They are quite different~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean in a different file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, would be nice in short term~
Create service calls to CloudAiCompanion from FDC Extension