Skip to content

Conversation

hlshen
Copy link
Contributor

@hlshen hlshen commented May 12, 2025

Create service calls to CloudAiCompanion from FDC Extension

@hlshen hlshen force-pushed the hlshen/gca-backend branch from f64f840 to 84e57f2 Compare May 12, 2025 23:07
@@ -0,0 +1,100 @@
import { ClientResponse, Client } from "../apiv2";
Copy link
Contributor

@fredzqm fredzqm May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this differ from code here?

https://github.com/firebase/firebase-tools/blame/58f56134e0a3436caf834691594c923ae5ec70f1/src/gif/fdcExperience.ts

Shall we build a shared client to talk to TAF?

cc @nohe427

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't. Unfortunately had this code sitting around for awhile. Do you mind if we push the merge to post I/O?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to unblock you in short term~

Though let's clean them up soon. It's fine to check-in unused experimental codes to master~

Feature branch is useful when we want to hide a launch from public in the FirebasePrivate repos. If it's already public, don't think there are much values keeping it un-merged for long.


/** Start Gemini client types */

export interface CallCloudAiCompanionRequest {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's separate the FDC API's types and Cloud AI Companion (TAF)'s types.

They are quite different~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean in a different file?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, would be nice in short term~

@fredzqm fredzqm enabled auto-merge (squash) May 14, 2025 00:13
@fredzqm fredzqm merged commit c2a66b3 into master May 14, 2025
50 checks passed
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants