Adding messaging APIs and mcp tools that take advantange of it #8558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsiddh
force-pushed
the
mcp-fm
branch
2 times, most recently
from
fdc2f60 to
c6672cf
Compare
fredzqm
approved these changes
May 13, 2025
| }, | ||
| }, | ||
| async ({ fcmToken, title, body }, { projectId }) => { | ||
| if (projectId === undefined) { |
There was a problem hiding this comment.
This isn't necessary. We have this check in the caller if requiresProject: true,
https://github.com/firebase/firebase-tools/blob/master/src/mcp/index.ts#L133
| }, | ||
| }, | ||
| async ({ topic, title, body }, { projectId }) => { | ||
| if (projectId === undefined) { |
github-project-automation
bot
moved this to Approved [PR]
in [Cloud] Extensions + Functions
github-project-automation
bot
moved this from Approved [PR]
to Done
in [Cloud] Extensions + Functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo: https://screencast.googleplex.com/cast/NDcyMTMxMzg3NTc1NTAwOHxiODY4MTk1MC01NA