-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[MCP] firebase init dataconnect tool #8562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/mcp/tools/core/init.ts
Outdated
export const init = tool( | ||
{ | ||
name: "init", | ||
description: "Initialize the Firebase Products. Provide the desired features information.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably need a longer/more robust description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Give it a shot. Though happy to take suggestions~
(Not as experienced in writing rules for LLM)
// Set force to true to avoid prompting the user for confirmation. | ||
await actuate(setup, config, { force: true }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way we can make force
a top-level tool param that defaults to false? Then catch conflicts and return an error describing the conflict and that {force: true}
is needed to proceed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like the idea~
Right now, force: false
would prompt. So the end user behavior is hanging.
I could follow up PR to make it error instead of hanging forever~
list_apps, | ||
get_sdk_config, | ||
consult_assistant, | ||
init, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you confident in landing additional products in init
before release cut on Thursday? I don't want to release init and it only works for one product, would rather leave commented out for now if so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to bugbash it today with the team~
I should be able to add more~
It takes some refactor, but not too hard. Likely will do RTDB, Firestore, storage, auth in this order (based on my familiarity)
Start with FDC, will add other products to the list gradually.