Skip to content

Conversation

fredzqm
Copy link
Contributor

@fredzqm fredzqm commented May 13, 2025

Start with FDC, will add other products to the list gradually.

Screenshot 2025-05-13 at 10 17 57 AM

@fredzqm fredzqm requested review from mbleigh, joehan and nohe427 May 13, 2025 17:18
@fredzqm fredzqm changed the base branch from master to fz/fdc-init May 13, 2025 17:19
export const init = tool(
{
name: "init",
description: "Initialize the Firebase Products. Provide the desired features information.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need a longer/more robust description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give it a shot. Though happy to take suggestions~

(Not as experienced in writing rules for LLM)

Comment on lines +69 to +70
// Set force to true to avoid prompting the user for confirmation.
await actuate(setup, config, { force: true });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way we can make force a top-level tool param that defaults to false? Then catch conflicts and return an error describing the conflict and that {force: true} is needed to proceed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the idea~

Right now, force: false would prompt. So the end user behavior is hanging.

I could follow up PR to make it error instead of hanging forever~

list_apps,
get_sdk_config,
consult_assistant,
init,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you confident in landing additional products in init before release cut on Thursday? I don't want to release init and it only works for one product, would rather leave commented out for now if so

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to bugbash it today with the team~

I should be able to add more~

It takes some refactor, but not too hard. Likely will do RTDB, Firestore, storage, auth in this order (based on my familiarity)

Base automatically changed from fz/fdc-init to master May 13, 2025 18:51
@fredzqm fredzqm enabled auto-merge (squash) May 13, 2025 19:51
@fredzqm fredzqm merged commit 4e31562 into master May 13, 2025
48 of 50 checks passed
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions May 13, 2025
@fredzqm fredzqm deleted the fz/mega-init branch May 13, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants