[MCP] Support init for database #8584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbleigh
approved these changes
May 15, 2025
Comment on lines
20
to
27
| rulesFilename: z | ||
| .string() | ||
| .default("database.rules.json") | ||
| .describe("The file to use for Realtime Database Security Rules."), | ||
| rules: z | ||
| .string() | ||
| .default(DEFAULT_RULES) | ||
| .describe("The security rules to use for Realtime Database Security Rules."), |
There was a problem hiding this comment.
Make both of these .optional() in addition to having defaults defined.
github-project-automation
bot
moved this to Approved [PR]
in [Cloud] Extensions + Functions
Only doing it because I already got familiar with its init code~ Firestore and storage will come very soon. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8584 +/- ##
==========================================
- Coverage 51.03% 51.01% -0.03%
==========================================
Files 426 426
Lines 30637 30664 +27
Branches 6286 6292 +6
==========================================
+ Hits 15636 15642 +6
- Misses 13607 13628 +21
Partials 1394 1394 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-project-automation
bot
moved this from Approved [PR]
to Done
in [Cloud] Extensions + Functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly refactors to make existing RTDB init flow fit into the MCP flow.
Init from an empty folder
firebase init database