[MCP] Create list_projects tool + slight modifications to list_apps #2 #8610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredzqm
reviewed
May 22, 2025
| ); | ||
| return toContent(apps); | ||
| } catch (err: any) { | ||
| const originalMessage = err.original ? `: ${err.original.message}` : ""; |
There was a problem hiding this comment.
Wonder if this logic is worth porting to the upstream exception handler.
It feels like a generic enough improvement.
https://github.com/firebase/firebase-tools/blob/master/src/mcp/index.ts#L223
There was a problem hiding this comment.
I think that would require some refactoring that I'd like to work on a separate PR
fredzqm
approved these changes
May 22, 2025
github-project-automation
bot
moved this to Approved [PR]
in [Cloud] Extensions + Functions
github-project-automation
bot
moved this from Approved [PR]
to Done
in [Cloud] Extensions + Functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create list_projects tool + slight modifications to list_apps
For some reason cursor keep breaking the tool without the change. It works much more consistently after removing the optional() part