Skip to content

Conversation

hlshen
Copy link
Contributor

@hlshen hlshen commented May 16, 2025

When inserting snippets, $ signs get treated as templates or variables. Need to escape them properly for inserting them literally.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.08%. Comparing base (2263d68) to head (91b47ee).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8614      +/-   ##
==========================================
+ Coverage   51.04%   51.08%   +0.03%     
==========================================
  Files         431      431              
  Lines       30986    31001      +15     
  Branches     6367     6368       +1     
==========================================
+ Hits        15818    15837      +19     
+ Misses      13752    13749       -3     
+ Partials     1416     1415       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hlshen hlshen enabled auto-merge (squash) May 16, 2025 15:55
@tammam-g tammam-g self-requested a review May 16, 2025 16:01
@hlshen hlshen merged commit 665e992 into master May 16, 2025
48 of 50 checks passed
@hlshen hlshen deleted the hlshen/dollar-fix branch May 16, 2025 16:02
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions May 16, 2025
TrCaM pushed a commit that referenced this pull request May 26, 2025
* escape the dollar sign for snipper insert

* change replaceAll to replace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants