Fix the type of eventFilters #8643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalej
approved these changes
May 22, 2025
There was a problem hiding this comment.
Please add a CHANGELOG.md entry. other than that LGTM!
Verified locally. TIL how to change the schema to be used in vscode. Using the updated schema with
.vscode/settings.json
{
"yaml.schemas": {
"../extension-yaml.json": ["extensions/firestore-bigquery-export/extension.yaml", "extensions/firestore-send-email/extension.yaml"],
// Or for multiple files:
// "./schemas/my-schema.json": ["*.config.yaml", "**/config/*.yaml"]
}
}
The error for eventFilters no longer appears
github-project-automation
bot
moved this to Approved [PR]
in [Cloud] Extensions + Functions
Skipping CHANGELOG for this because its not really something included in the release - Schema Store and other places just pull this from github raw content. |
github-project-automation
bot
moved this from Approved [PR]
to Done
in [Cloud] Extensions + Functions
TrCaM
pushed a commit
that referenced
this pull request
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
eventFilters should be an array of objects, not a string. Fixes #8630