Split confirmWriteProjectFile out of askWriteProjectFile #8648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehan
approved these changes
May 23, 2025
src/config.ts
Outdated
| message: "File " + clc.underline(path) + " already exists. Overwrite?", | ||
| default: !!confirmByDefault, | ||
| }); | ||
| if (shouldWrite) { |
There was a problem hiding this comment.
This seems reversed - shouldn't it be !shouldWrite
There was a problem hiding this comment.
Thanks a bunch!
Missed the case when file changed in manual testing.
github-project-automation
bot
moved this to Approved [PR]
in [Cloud] Extensions + Functions
github-project-automation
bot
moved this from Approved [PR]
to Done
in [Cloud] Extensions + Functions
TrCaM
pushed a commit
that referenced
this pull request
May 26, 2025
* split confirmWriteProjectFile out of askWriteProjectFile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing some refactor to make split prompt and file write actuation easier.
config.writeProjectFilemethod. Audited all use cases of it and update surrounding logs to avoid duplications.confirmWriteProjectFileout ofaskWriteProjectFile.It's very common in
doSetupto useaskWriteProjectFile.After the refactor, we can make
askQuestionscallsconfirmWriteProjectFileand saves the response.actuatecallsaskWriteProjectFile.From Empty Folder
Re-running init again
It's arguably better than the existing behavior, which ask for confirmation even if there is no change in Firestore / storage rules.
[Existing] Re-running init