Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions schema/firebase-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -1107,6 +1107,9 @@
},
"type": "array"
},
"localBuild": {
"type": "boolean"
},
"rootDir": {
"type": "string"
}
Expand Down Expand Up @@ -1134,6 +1137,9 @@
},
"type": "array"
},
"localBuild": {
"type": "boolean"
},
"rootDir": {
"type": "string"
}
Expand Down
1 change: 1 addition & 0 deletions src/deploy/apphosting/release.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
archive: {
userStorageUri: storageUri,
rootDirectory: config.rootDir,
locallyBuiltSource: config.localBuild,
},
},
},
Expand All @@ -67,7 +68,7 @@
logLabeledSuccess("apphosting", `Your backend is now deployed at:\n\thttps://${backend.uri}`);
} else {
logLabeledWarning("apphosting", `Rollout for backend ${backendIds[i]} failed.`);
logLabeledError("apphosting", res.reason);

Check warning on line 71 in src/deploy/apphosting/release.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unsafe argument of type `any` assigned to a parameter of type `string`
}
}
rolloutsSpinner.stop();
Expand Down
1 change: 1 addition & 0 deletions src/firebaseConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,7 @@ export type AppHostingSingle = {
rootDir: string;
ignore: string[];
alwaysDeployFromSource?: boolean;
localBuild?: boolean;
};

export type AppHostingMultiple = AppHostingSingle[];
Expand Down
3 changes: 3 additions & 0 deletions src/gcp/apphosting.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@
export interface BuildConfig {
minInstances?: number;
memory?: string;
env?: string[];
runCommand?: string;
}

interface BuildSource {
Expand Down Expand Up @@ -129,6 +131,7 @@
// end oneof reference
rootDirectory?: string;
author?: SourceUserMetadata;
locallyBuiltSource?: boolean;
}

interface SourceUserMetadata {
Expand Down Expand Up @@ -271,7 +274,7 @@
done: boolean;
// oneof result
error?: Status;
response?: any;

Check warning on line 277 in src/gcp/apphosting.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unexpected any. Specify a different type
// end oneof result
}

Expand Down Expand Up @@ -687,14 +690,14 @@
/**
* Ensure that the App Hosting API is enabled on the project.
*/
export async function ensureApiEnabled(options: any): Promise<void> {

Check warning on line 693 in src/gcp/apphosting.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unexpected any. Specify a different type
const projectId = needProjectId(options);

Check warning on line 694 in src/gcp/apphosting.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unsafe argument of type `any` assigned to a parameter of type `{ projectId?: string | undefined; project?: string | undefined; rc?: RC | undefined; }`
return await ensure(projectId, apphostingOrigin(), "app hosting", true);
}

/**
* Generates the next build ID to fit with the naming scheme of the backend API.
* @param counter Overrides the counter to use, avoiding an API call.

Check warning on line 700 in src/gcp/apphosting.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Expected @param names to be "projectId, location, backendId, counter". Got "counter"
*/
export async function getNextRolloutId(
projectId: string,
Expand Down
Loading