-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[VS Code] Remove unused codes associated with gca cmds #9117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @fredzqm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on a significant cleanup and refactoring effort within the VS Code extension by removing all code paths and dependencies related to the Gemini Code Assist (GCA) and Cloud AI Companion API integrations. The primary goal is to streamline the codebase, remove deprecated features, and reduce the overall project footprint.
Highlights
- Gemini Code Assist (GCA) Integration Removal: The entire integration with Gemini Code Assist (GCA) and its associated AI-powered code generation features have been removed from the VS Code extension. This includes disabling the GCA tool client and controller.
- Cloud AI Companion API Client Deprecation: The dedicated client for the Cloud AI Companion API, along with its unit tests, has been completely removed, signifying the deprecation of these AI-driven functionalities.
- Dependency Cleanup: Unused development dependencies, specifically those related to
@puppeteer/browsers
,chromium-bidi
,devtools-protocol
,puppeteer-core
, andzod
, have been removed frompackage-lock.json
, streamlining the project's dependencies.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively removes unused code associated with Gemini Code Assist commands. The changes include deleting dependencies, client files, and cleaning up related imports and service methods. My main feedback is on two files that have been entirely commented out. For better code maintainability, it's preferable to delete unused files rather than commenting them out to avoid clutter and potential confusion for future developers.
@hlshen Here is a clean up PR to remove dead code. Please take a look~ |
No description provided.