(feat) Crashlytics tools improvements #9138

maxl0rd · 2025-09-17T20:19:38Z

Description

Making interval handling more robust
Adding return messages to avoid undefined tool responses
Adding BatchGetEvents

- Making interval handling more robust - Adding return messages to avoid undefined tool responses

gemini-code-assist

Summary of Changes

Hello @maxl0rd, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Crashlytics tools by introducing a new capability to batch retrieve events, which improves efficiency when fetching multiple event details. It also makes the handling of time-based filters more resilient by ensuring that report queries always have a complete time interval. Furthermore, the changes refine the API interactions for updating issues and deleting notes, providing clearer feedback and more consistent request structures. These improvements aim to make the Crashlytics integration more robust and user-friendly for developers.

Highlights

New Batch Event Retrieval: Introduced a new batchGetEvents function and associated types, allowing for the efficient retrieval of multiple Crashlytics events by their resource names, with a limit of 100 events per batch.
Robust Interval Handling: Improved the handling of time intervals in Crashlytics reports by automatically setting intervalEndTime to the current time if intervalStartTime is provided without an end time, making interval queries more robust.
Enhanced Tool Responses and API Consistency: Updated the deleteNote function to return a confirmation message upon successful deletion and refined API request bodies for issue updates and tool definitions for better consistency and clarity.
Updated Tool Definitions and Prompts: Renamed Crashlytics tools in prompts (e.g., list_top_issues to get_top_issues) and added more detailed instructions for applying filters (like issueErrorType and time intervals) when using these tools.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces several improvements to the Crashlytics tools. It adds a new batchGetEvents function to fetch multiple events at once, including corresponding types and tests. It also makes interval handling more robust by setting a default end time if only a start time is provided. Additionally, it improves user feedback by adding a return message to the deleteNote function. The changes are well-structured and include necessary updates to tests and type definitions. My review includes one suggestion to improve maintainability by replacing a magic number with a constant.

src/crashlytics/events.ts

schnecle

A couple small things, nothing blocking from my end.

schnecle · 2025-09-17T20:26:27Z

src/crashlytics/events.ts

+  eventNames: string[],
+): Promise<BatchGetEventsResponse> {
+  const requestProjectNumber = parseProjectNumber(appId);
+  if (eventNames.length > 100) throw new FirebaseError("Too many events in batchGet request");


Should we even let this many come through? I feel like we shouldn't pull back more than like 30 tops to keep the context window from blowing up.

I haven't written the tool yet, but I think we could limit it there. These defs map to the api's limits.

schnecle · 2025-09-17T20:27:00Z

src/crashlytics/filters.ts

+    intervalStartTime: z
+      .string()
+      .optional()
+      .describe(`A timestamp in ISO 8601 string format. Defaults to 7 days ago.`),


Should we add the default value to zod?

We wouldn't want a static timestamp burned into the tool definition.

schnecle · 2025-09-17T20:29:24Z

src/crashlytics/events.ts

+ * Format: "projects/{project}/apps/{app_id}/events/{event_id}"
+ * @return A BatchGetEventsResponse including an array of Event.
+ */
+export async function batchGetEvents(


It looks like we don't have a tool defined for this - do we want to use this now? Should we keep it out of here until we find we have a need for it?

This should be fine to add the library method here, but I want to do more testing before adding the tool.

- Improving instructions and return values in crashlytics tools - Making interval handling more robust - Adding return messages to avoid undefined tool responses

maxl0rd added 2 commits September 17, 2025 16:09

feat: Improving instructions and return values in crashlytics tools

580ce32

- Making interval handling more robust - Adding return messages to avoid undefined tool responses

(fix) Fixing method signatures in crashlytics tools

6837f9f

github-project-automation bot added this to [Cloud] Extensions + Functions Sep 17, 2025

gemini-code-assist bot reviewed Sep 17, 2025

View reviewed changes

src/crashlytics/events.ts Show resolved Hide resolved

schnecle approved these changes Sep 17, 2025

View reviewed changes

github-project-automation bot moved this to Approved [PR] in [Cloud] Extensions + Functions Sep 17, 2025

maxl0rd merged commit e5343ea into master Sep 17, 2025
48 checks passed

maxl0rd deleted the ml_crashlytics_tools2 branch September 17, 2025 20:42

github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Sep 17, 2025

bkendall pushed a commit that referenced this pull request Sep 17, 2025

(feat) Crashlytics tools improvements (#9138)

ece5bcd

- Improving instructions and return values in crashlytics tools - Making interval handling more robust - Adding return messages to avoid undefined tool responses

annajowang pushed a commit that referenced this pull request Sep 19, 2025

(feat) Crashlytics tools improvements (#9138)

2c4dfde

- Improving instructions and return values in crashlytics tools - Making interval handling more robust - Adding return messages to avoid undefined tool responses

This was referenced Sep 22, 2025

parse adapter build #9159

Draft

call loca #9162

Closed

Fix lint and test errors from master merge #9192

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

(feat) Crashlytics tools improvements #9138

(feat) Crashlytics tools improvements #9138

Uh oh!

maxl0rd commented Sep 17, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

schnecle left a comment

Uh oh!

schnecle Sep 17, 2025

Uh oh!

maxl0rd Sep 17, 2025

Uh oh!

schnecle Sep 17, 2025

Uh oh!

maxl0rd Sep 17, 2025

Uh oh!

schnecle Sep 17, 2025

Uh oh!

maxl0rd Sep 17, 2025

Uh oh!

Uh oh!

Uh oh!

(feat) Crashlytics tools improvements #9138

(feat) Crashlytics tools improvements #9138

Uh oh!

Conversation

maxl0rd commented Sep 17, 2025

Description

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

schnecle left a comment

Choose a reason for hiding this comment

Uh oh!

schnecle Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

maxl0rd Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

schnecle Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

maxl0rd Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

schnecle Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

maxl0rd Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!