-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[MCP] firebase_update_environment
tool can be used to accept Gemini in Firebase ToS
#9143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @fredzqm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Firebase CLI's Model Context Protocol (MCP) tools by integrating Gemini in Firebase Terms of Service acceptance directly into the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a valuable feature, allowing users to accept the Gemini in Firebase Terms of Service via the firebase_update_environment
tool. The implementation is solid, centralizing logic in new helper functions and using metadata flags for better tool definitions. I have a couple of minor suggestions to enhance code clarity and improve a user-facing message.
While Joe is out. @yuchenshi Can you take a look? You have good context from today's friction meetings. |
… in Firebase ToS (#9143) * update_environment can be used to accept Gemini ToS * changelog * Update src/mcp/tools/core/update_environment.ts Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * m * m * m * m * m --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
https://screencast.googleplex.com/cast/NTg2MTc0MDAzMzA4MTM0NHwyZGM3YTFjNi1jMw
While I am at it, improved the error message when projectId is missing.