Skip to content

Conversation

fredzqm
Copy link
Contributor

@fredzqm fredzqm commented Sep 18, 2025

https://screencast.googleplex.com/cast/NTg2MTc0MDAzMzA4MTM0NHwyZGM3YTFjNi1jMw

Screenshot 2025-09-18 at 4 28 48 PM

While I am at it, improved the error message when projectId is missing.

Copy link
Contributor

Summary of Changes

Hello @fredzqm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Firebase CLI's Model Context Protocol (MCP) tools by integrating Gemini in Firebase Terms of Service acceptance directly into the firebase_update_environment tool. It refactors the logic for checking Gemini API enablement into a dedicated function and updates the environment reporting tool to display the Gemini ToS status. Additionally, it introduces a mechanism to allow certain tools to operate without a pre-existing project directory, improving the flexibility of environment setup and recovery.

Highlights

  • Gemini in Firebase ToS Acceptance: The firebase_update_environment tool now includes an option (accept_gemini_tos) to accept the Gemini in Firebase Terms of Service, streamlining the setup process for Gemini-related features.
  • Refactored Gemini API Checks: A new requireGeminiToS function has been introduced in src/mcp/errors.ts to centralize the logic for checking and enabling the Gemini in Firebase API, improving code reusability and clarity.
  • Enhanced Environment Reporting: The firebase_get_environment tool now reports the status of the Gemini in Firebase Terms of Service acceptance, providing better visibility into the environment configuration.
  • Flexible Project Directory Requirement: A new optionalProjectDir meta-property has been added to ServerTool to allow certain tools, like firebase_update_environment, to function even without an active project directory, enabling them to fix environment issues.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a valuable feature, allowing users to accept the Gemini in Firebase Terms of Service via the firebase_update_environment tool. The implementation is solid, centralizing logic in new helper functions and using metadata flags for better tool definitions. I have a couple of minor suggestions to enhance code clarity and improve a user-facing message.

fredzqm and others added 7 commits September 18, 2025 16:29
@fredzqm fredzqm requested a review from yuchenshi September 18, 2025 23:37
@fredzqm
Copy link
Contributor Author

fredzqm commented Sep 18, 2025

While Joe is out.

@yuchenshi Can you take a look? You have good context from today's friction meetings.

@fredzqm fredzqm enabled auto-merge (squash) September 19, 2025 17:04
@fredzqm fredzqm merged commit 3b874f7 into master Sep 19, 2025
48 checks passed
@fredzqm fredzqm deleted the fz/gemini-tos branch September 19, 2025 19:11
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Sep 19, 2025
annajowang pushed a commit that referenced this pull request Sep 19, 2025
… in Firebase ToS (#9143)

* update_environment can be used to accept Gemini ToS

* changelog

* Update src/mcp/tools/core/update_environment.ts

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* m

* m

* m

* m

* m

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants