-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update mcp README.md tools list #9144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @fredzqm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the list of available tools in the MCP server's README. The changes include adding several new tools for Data Connect and Crashlytics, updating the description for firebase_consult_assistant
to be more detailed, and adjusting the descriptions for the database
tools. While the more detailed description for the assistant is a great improvement, I've found significant inconsistencies between the tool names and descriptions in the README and their implementation in the code. I've also suggested improvements to the database
tool descriptions for clarity and consistency. Please see my detailed comments.
| database_get_data | database | Returns RTDB data from the specified location | | ||
| database_set_data | database | Writes RTDB data to the specified location | | ||
| database_get_rules | database | Get an RTDB database's rules | | ||
| database_validate_rules | database | Validates an RTDB database's rules | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated descriptions for the database
tools are less clear and grammatically inconsistent with the rest of the table. For example, "Get an RTDB database's rules" is awkward, and all four descriptions are missing a trailing period.
For better readability and consistency, I suggest revising them to be more descriptive, like the previous versions.
| database_get_data | database | Returns RTDB data from the specified location | | |
| database_set_data | database | Writes RTDB data to the specified location | | |
| database_get_rules | database | Get an RTDB database's rules | | |
| database_validate_rules | database | Validates an RTDB database's rules | | |
| database_get_data | database | Returns RTDB data from the specified location. | | |
| database_set_data | database | Writes RTDB data to the specified location. | | |
| database_get_rules | database | Retrieves the security rules for the database. | | |
| database_validate_rules | database | Validates the security rules for the database. | |
This is generated by:
npx firebase-tools experimental:mcp --generate-tool-list