-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[MCP] Update GEMINI_TOS_ERROR #9156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @fredzqm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a minor but important text update to an error message within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates an error message for the Gemini Terms of Service, changing 'API' to 'features' for better clarity. The change is an improvement. I've also suggested a minor code style refinement to use a template literal for the multi-line string, which aligns with the existing style in the file.
src/mcp/errors.ts
Outdated
"This tool requires the Gemini in Firebase features, please review the terms of service and accept it using `firebase_update_environment`.\n" + | ||
"Learn more about Gemini in Firebase and how it uses your data: https://firebase.google.com/docs/gemini-in-firebase#how-gemini-in-firebase-uses-your-data", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For improved readability and consistency with other multi-line strings in this file (e.g., in noProjectDirectory
and mcpAuthError
), consider using a template literal here. This combines the concatenated parts into a single, cleaner expression.
"This tool requires the Gemini in Firebase features, please review the terms of service and accept it using `firebase_update_environment`.\n" + | |
"Learn more about Gemini in Firebase and how it uses your data: https://firebase.google.com/docs/gemini-in-firebase#how-gemini-in-firebase-uses-your-data", | |
`This tool requires the Gemini in Firebase features, please review the terms of service and accept it using \`firebase_update_environment\`.\nLearn more about Gemini in Firebase and how it uses your data: https://firebase.google.com/docs/gemini-in-firebase#how-gemini-in-firebase-uses-your-data`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Update GEMINI_TOS_ERROR * merge * m
Description
Scenarios Tested
Sample Commands