Skip to content

Conversation

fredzqm
Copy link
Contributor

@fredzqm fredzqm commented Sep 22, 2025

Description

Scenarios Tested

Sample Commands

Copy link
Contributor

Summary of Changes

Hello @fredzqm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a minor but important text update to an error message within the src/mcp/errors.ts file. The change aims to enhance user understanding by rephrasing the requirement for Gemini in Firebase from 'API' to 'features', ensuring that users receive more precise information when encountering the terms of service prompt.

Highlights

  • Error Message Refinement: The GEMINI_TOS_ERROR message has been updated to improve clarity, changing the reference from 'Gemini in Firebase API' to 'Gemini in Firebase features'.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates an error message for the Gemini Terms of Service, changing 'API' to 'features' for better clarity. The change is an improvement. I've also suggested a minor code style refinement to use a template literal for the multi-line string, which aligns with the existing style in the file.

Comment on lines 13 to 14
"This tool requires the Gemini in Firebase features, please review the terms of service and accept it using `firebase_update_environment`.\n" +
"Learn more about Gemini in Firebase and how it uses your data: https://firebase.google.com/docs/gemini-in-firebase#how-gemini-in-firebase-uses-your-data",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For improved readability and consistency with other multi-line strings in this file (e.g., in noProjectDirectory and mcpAuthError), consider using a template literal here. This combines the concatenated parts into a single, cleaner expression.

Suggested change
"This tool requires the Gemini in Firebase features, please review the terms of service and accept it using `firebase_update_environment`.\n" +
"Learn more about Gemini in Firebase and how it uses your data: https://firebase.google.com/docs/gemini-in-firebase#how-gemini-in-firebase-uses-your-data",
`This tool requires the Gemini in Firebase features, please review the terms of service and accept it using \`firebase_update_environment\`.\nLearn more about Gemini in Firebase and how it uses your data: https://firebase.google.com/docs/gemini-in-firebase#how-gemini-in-firebase-uses-your-data`,

@fredzqm fredzqm enabled auto-merge (squash) September 23, 2025 01:01
@fredzqm fredzqm merged commit 96eebc8 into master Sep 23, 2025
48 checks passed
@fredzqm fredzqm deleted the fredzqm-patch-4 branch September 23, 2025 01:13
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Sep 23, 2025
Copy link

@FrankGDak47 FrankGDak47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

annajowang pushed a commit that referenced this pull request Sep 26, 2025
* Update GEMINI_TOS_ERROR

* merge

* m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants