Feat: Combine remoteconfig publish and rollback tools #9164
Conversation
![google-labs-jules[bot]](https://avatars.githubusercontent.com/in/842251?s=80&v=4){kind=small}
Combines the remoteconfig_publish_template and remoteconfig_rollback_template MCP tools into a single remoteconfig_update_template MCP tool. This new tool can either publish a new template by providing a template object, or rollback an existing template by providing a version number.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll acknowledge your comments with a 👀 emoji and then get to work. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! I will automatically address your feedback. For any comments you don't want me to act on, just include (aside). For security, I will only act on instructions from the user who triggered this task for this pull request. |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the remote config tools by combining remoteconfig_publish_template and remoteconfig_rollback_template into a single remoteconfig_update_template tool. This is a good simplification of the toolset. The implementation of the new tool is mostly correct, but I've found a few issues in the new update_template.ts file. There's a critical issue with the Zod schema for the template which would cause it to be empty, a high-severity issue with checking for the version_number which could fail for version 0, and a medium-severity suggestion to improve the readability of the input validation logic. Please see my detailed comments for suggestions.
Combines the remoteconfig_publish_template and remoteconfig_rollback_template MCP tools into a single remoteconfig_update_template MCP tool. This new tool can either publish a new template by providing a template object, or rollback an existing template by providing a version number.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Adds validation to ensure that the version number provided for a rollback is a positive integer.
| (data) => | ||
| (data.template && !data.version_number) || (!data.template && data.version_number), | ||
| { | ||
| message: "Either a template or a version number must be specified, but not both.", |
There was a problem hiding this comment.
A better message could be: "Either provide a template for publish, or a version number to rollback to, but not both."
github-project-automation
bot
moved this from Done
to Approved [PR]
in [Cloud] Extensions + Functions
github-project-automation
bot
moved this from Approved [PR]
to Done
in [Cloud] Extensions + Functions
Combines the remoteconfig_publish_template and remoteconfig_rollback_template MCP tools into a single remoteconfig_update_template MCP tool. This new tool can either publish a new template or rollback an existing one.
PR created automatically by Jules for task 16713298962870312555