-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Support preview releases in publish script #9170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The publish script has been updated to support a new 'preview' version. When releasing a preview version, the following changes occur: - A branch name must be provided, and the release will be built from that branch. - The npm package is published with a '--tag=preview' flag. - The following steps are skipped: - Pushing changes to the master branch. - Creating a GitHub release. - Generating firepit artifacts. - Generating a Docker image.
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll acknowledge your comments with a 👀 emoji and then get to work. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! I will automatically address your feedback. For any comments you don't want me to act on, just include (aside). For security, I will only act on instructions from the user who triggered this task for this pull request. |
Updates the preview release functionality to include the sanitized branch name in the npm prerelease version string and the npm distribution tag. This allows for multiple preview versions from different branches to coexist without conflicting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I give this "doesn't seem obviously bad" level of LGTM but I'm not familiar enough with the scripts to give it a thorough review.
Lots of duplicated code for skipping things...is there a better way to do things conditionally?
* feat: support preview releases in publish script The publish script has been updated to support a new 'preview' version. When releasing a preview version, the following changes occur: - A branch name must be provided, and the release will be built from that branch. - The npm package is published with a '--tag=preview' flag. - The following steps are skipped: - Pushing changes to the master branch. - Creating a GitHub release. - Generating firepit artifacts. - Generating a Docker image. * feat: include branch name in preview release version and tag Updates the preview release functionality to include the sanitized branch name in the npm prerelease version string and the npm distribution tag. This allows for multiple preview versions from different branches to coexist without conflicting. --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
* feat: support preview releases in publish script The publish script has been updated to support a new 'preview' version. When releasing a preview version, the following changes occur: - A branch name must be provided, and the release will be built from that branch. - The npm package is published with a '--tag=preview' flag. - The following steps are skipped: - Pushing changes to the master branch. - Creating a GitHub release. - Generating firepit artifacts. - Generating a Docker image. * feat: include branch name in preview release version and tag Updates the preview release functionality to include the sanitized branch name in the npm prerelease version string and the npm distribution tag. This allows for multiple preview versions from different branches to coexist without conflicting. --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
This change updates the release script to support preview versions. It accepts a new option for the version argument 'preview', and an additional argument 'branch'. Instead of building off of master, it builds off of that provided branch. When releasing a preview version, it skips pushing changes back to the master branch, uploading a github release, generating firepit artifacts, and generating a docker image.
PR created automatically by Jules for task 17516625543263453881