Skip to content

Conversation

google-labs-jules[bot]
Copy link
Contributor

This change updates the release script to support preview versions. It accepts a new option for the version argument 'preview', and an additional argument 'branch'. Instead of building off of master, it builds off of that provided branch. When releasing a preview version, it skips pushing changes back to the master branch, uploading a github release, generating firepit artifacts, and generating a docker image.


PR created automatically by Jules for task 17516625543263453881

The publish script has been updated to support a new 'preview' version.
When releasing a preview version, the following changes occur:

- A branch name must be provided, and the release will be built from that branch.
- The npm package is published with a '--tag=preview' flag.
- The following steps are skipped:
  - Pushing changes to the master branch.
  - Creating a GitHub release.
  - Generating firepit artifacts.
  - Generating a Docker image.
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll acknowledge your comments with a 👀 emoji and then get to work. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

I will automatically address your feedback. For any comments you don't want me to act on, just include (aside).



For security, I will only act on instructions from the user who triggered this task for this pull request.

Updates the preview release functionality to include the sanitized
branch name in the npm prerelease version string and the npm
distribution tag.

This allows for multiple preview versions from different branches to
coexist without conflicting.
@joehan joehan requested a review from mbleigh September 23, 2025 20:12
@joehan joehan marked this pull request as ready for review September 23, 2025 20:13
Copy link
Contributor

@mbleigh mbleigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I give this "doesn't seem obviously bad" level of LGTM but I'm not familiar enough with the scripts to give it a thorough review.

Lots of duplicated code for skipping things...is there a better way to do things conditionally?

@joehan joehan enabled auto-merge (squash) September 24, 2025 22:06
@joehan joehan merged commit f204a8f into master Sep 24, 2025
48 checks passed
@joehan joehan deleted the feature/preview-release branch September 24, 2025 22:19
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Sep 24, 2025
annajowang pushed a commit that referenced this pull request Sep 26, 2025
* feat: support preview releases in publish script

The publish script has been updated to support a new 'preview' version.
When releasing a preview version, the following changes occur:

- A branch name must be provided, and the release will be built from that branch.
- The npm package is published with a '--tag=preview' flag.
- The following steps are skipped:
  - Pushing changes to the master branch.
  - Creating a GitHub release.
  - Generating firepit artifacts.
  - Generating a Docker image.

* feat: include branch name in preview release version and tag

Updates the preview release functionality to include the sanitized
branch name in the npm prerelease version string and the npm
distribution tag.

This allows for multiple preview versions from different branches to
coexist without conflicting.

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
jrothfeder pushed a commit that referenced this pull request Oct 2, 2025
* feat: support preview releases in publish script

The publish script has been updated to support a new 'preview' version.
When releasing a preview version, the following changes occur:

- A branch name must be provided, and the release will be built from that branch.
- The npm package is published with a '--tag=preview' flag.
- The following steps are skipped:
  - Pushing changes to the master branch.
  - Creating a GitHub release.
  - Generating firepit artifacts.
  - Generating a Docker image.

* feat: include branch name in preview release version and tag

Updates the preview release functionality to include the sanitized
branch name in the npm prerelease version string and the npm
distribution tag.

This allows for multiple preview versions from different branches to
coexist without conflicting.

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants