Skip to content

Conversation

mbleigh
Copy link
Contributor

@mbleigh mbleigh commented Sep 24, 2025

image

Copy link
Contributor

Summary of Changes

Hello @mbleigh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors how users interact with the Firebase Assistant within the mcp framework. By transitioning the 'consult' functionality from a traditional 'tool' to a more direct 'prompt', the change aims to provide a more intuitive and guided experience for querying Firebase documentation and assistance. The update also enhances user guidance by explicitly handling cases where a project context is required for the assistant's operation.

Highlights

  • Refactoring of Firebase Assistant Interaction: The core functionality for consulting the Firebase Assistant has been refactored from a 'tool' to a 'prompt' within the mcp system.
  • New consult Prompt Introduced: A new consult prompt has been added, enabling users to directly ask questions to the Firebase Assistant (powered by the Gemini model) and receive detailed responses based on Firebase documentation and context.
  • Removal of consult_assistant Tool: The previous consult_assistant tool has been removed, streamlining the interaction method to the new prompt-based approach.
  • Improved Project Context Handling: The new consult prompt includes logic to inform users if a projectId is missing and guides them on how to set it, ensuring proper context for Firebase Assistant queries.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the consult functionality from a tool to a prompt. The implementation is clean and the refactoring is well-executed across the files. I've identified one potential issue in the new consult.ts file where an empty or missing response from the assistant could lead to an undesirable "undefined" string in a follow-up prompt. My feedback includes a small suggestion to handle this case more gracefully.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@mbleigh mbleigh enabled auto-merge (squash) September 24, 2025 18:09
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs linting

@mbleigh mbleigh merged commit 8f5ae01 into master Sep 24, 2025
48 checks passed
@mbleigh mbleigh deleted the mb/mcp/consult branch September 24, 2025 19:07
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants