Set local build configs throughout the deploy steps #9184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annajowang
force-pushed
the
createArchive-subdir
branch
from
1e82524 to
0a3e28c
Compare
annajowang
force-pushed
the
deploy-local-builds
branch
from
583f27b to
8b939b3
Compare
annajowang
changed the title
annajowang
force-pushed
the
createArchive-subdir
branch
from
0a3e28c to
cd37899
Compare
annajowang
force-pushed
the
deploy-local-builds
branch
from
2a2b717 to
d9896d8
Compare
annajowang
force-pushed
the
createArchive-subdir
branch
from
cd37899 to
013cf75
Compare
annajowang
force-pushed
the
deploy-local-builds
branch
from
d9896d8 to
0306fdc
Compare
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for local builds in App Hosting. The changes correctly modify the prepare and deploy steps to handle local build artifacts, including creating separate GCS buckets and passing build configurations. My review includes suggestions to improve type safety, make the code more robust against unexpected build outputs, and clarify logging messages for a better user experience.
annajowang
force-pushed
the
deploy-local-builds
branch
from
0306fdc to
e487144
Compare
annajowang
force-pushed
the
deploy-local-builds
branch
from
e487144 to
394a83a
Compare
Yuangwang
approved these changes
Sep 25, 2025
github-project-automation
bot
moved this to Approved [PR]
in [Cloud] Extensions + Functions
github-project-automation
bot
moved this from Approved [PR]
to Done
in [Cloud] Extensions + Functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the deploy context config for localBuild backends