-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update auth, firestore, and hosting instructions #9186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @kmandrika, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the instructional guides for Firebase Authentication, Firestore, and Hosting. The primary goal is to enhance clarity, improve the logical flow of steps, and incorporate critical security best practices, particularly regarding automated security rule updates and pre-deployment checks for public rules. These updates ensure developers follow the latest recommendations and maintain a secure deployment posture. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the instruction prompts for Auth, Firestore, and Hosting. The changes introduce a clearer, more structured format using markdown headings, which significantly improves readability. The instructions themselves are also updated to be more specific and actionable for the target AI agent. I've found one minor ambiguity in the Firestore guide and suggested a clarification. Overall, these are great improvements.
- Guide developers to verify database creation at the [Firebase Console](https://console.firebase.google.com/) | ||
- Navigate to "Firestore Database" in the left navigation to confirm database creation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The instructions for verification are split into two lines, which creates some ambiguity. Line 27 says to 'Guide developers', while line 28 begins with 'Navigate to...'. It's not perfectly clear whether the agent is supposed to perform the navigation or if this is part of the guidance for the developer. Combining these into a single, unambiguous instruction would be better for clarity.
- Guide developers to verify database creation at the [Firebase Console](https://console.firebase.google.com/) | |
- Navigate to "Firestore Database" in the left navigation to confirm database creation | |
- Guide developers to verify database creation at the [Firebase Console](https://console.firebase.google.com/) by navigating to "Firestore Database" in the left navigation to confirm database creation |
Description
Update the Auth, Firestore, and Hosting prompts based on the latest versions.