Skip to content

Conversation

samedson
Copy link
Contributor

Copy link
Contributor

Summary of Changes

Hello @samedson, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a crucial change to prevent the automatic acceptance of Gemini Terms of Service within Firebase. It modifies a core prompt to explicitly instruct the system to seek user consent for the terms and to halt the process if acceptance is not granted, thereby reinforcing user control and ensuring proper compliance with terms of service agreements.

Highlights

  • Explicit User Consent for Terms of Service: The system now explicitly prompts for user acceptance of terms of service when required conditions are missing, specifically preventing automatic progression without consent. This change ensures that users must actively agree to the terms before proceeding.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the consult prompt to prevent automatic acceptance of the Gemini in Firebase Terms of Service. The change adds an explicit instruction to the language model to ask for user consent before proceeding with accepting the terms. This is a good improvement for user control and transparency. My review includes a suggestion to make the instruction to the model even more explicit to ensure predictable behavior.

samedson and others added 2 commits September 30, 2025 16:40
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love the leagally binding 'ya' in your example 😆

@joehan joehan merged commit bbce454 into master Sep 30, 2025
48 checks passed
@joehan joehan deleted the samedson-no-auto-terms branch September 30, 2025 21:34
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants