-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Prevent auto-acceptance of Gemini in Firebase Terms #9216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @samedson, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a crucial change to prevent the automatic acceptance of Gemini Terms of Service within Firebase. It modifies a core prompt to explicitly instruct the system to seek user consent for the terms and to halt the process if acceptance is not granted, thereby reinforcing user control and ensuring proper compliance with terms of service agreements. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the consult
prompt to prevent automatic acceptance of the Gemini in Firebase Terms of Service. The change adds an explicit instruction to the language model to ask for user consent before proceeding with accepting the terms. This is a good improvement for user control and transparency. My review includes a suggestion to make the instruction to the model even more explicit to ensure predictable behavior.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love the leagally binding 'ya' in your example 😆
Before: https://paste.googleplex.com/5683952648060928
After: https://paste.googleplex.com/6585681937825792