Skip to content

Conversation

charlotteliang
Copy link
Contributor

@charlotteliang charlotteliang commented Oct 1, 2025

  • Remove redundant security rule clarification now that we have security rule example shown below
  • Add clarification to prevent users manually create database on the console
  • Add clarification to ask gemini to explain to users about security rules before deploying them
  • Clarify schema terminology and show users the app schema by default.

Copy link
Contributor

Summary of Changes

Hello @charlotteliang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the Firestore initialization prompt to be more succinct and user-friendly. It focuses on improving the clarity of instructions for database setup, deployment, and security rule handling, ensuring users are guided effectively without unnecessary details or potential missteps like manual console database creation.

Highlights

  • Prompt Conciseness: Removed redundant security rule clarification, streamlining the Firestore setup prompt.
  • Database Creation Guidance: Added clarification to prevent users from manually creating databases on the console, guiding them to use firebase deploy instead.
  • Security Rules Explanation: Included a new instruction to ask Gemini to explain security rules to users and obtain confirmation before deploying them.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Firestore initialization guide to be more succinct and direct. The changes remove redundant sections and clarify instructions for the AI agent. My review includes a couple of suggestions to improve the grammar and clarity of the instructions to ensure they are interpreted correctly by the agent.

Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits, but seems fine to me - lets get Sam's review on this too since he's been editting the prompt more actively than I have been.

Copy link
Contributor Author

@charlotteliang charlotteliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added fixes based on the review

Copy link
Contributor

@samedson samedson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - I think you'll just need to rebase and include the changes from https://github.com/firebase/firebase-tools/pull/9218/files

@charlotteliang charlotteliang enabled auto-merge (squash) October 1, 2025 16:47
@charlotteliang charlotteliang merged commit 789263e into master Oct 1, 2025
48 checks passed
@charlotteliang charlotteliang deleted the firestore-prompt-trim branch October 1, 2025 17:00
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants