-
Notifications
You must be signed in to change notification settings - Fork 1.1k
add MCP tool to get functions log tool #9231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @taeold, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the log retrieval capabilities within the Managed Control Plane by introducing a dedicated tool for Cloud Functions. It enables users to query and analyze function logs with greater flexibility through advanced filtering, sorting, and pagination. The underlying Cloud Logging API integration was updated to support these features, ensuring a robust and scalable solution for log management. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new MCP tool for retrieving Cloud Functions logs and refactors the Cloud Logging API client to support pagination. The changes are well-structured, with new functionality being properly typed, validated, and tested. The refactoring for pagination is applied consistently across all call sites. I have a couple of suggestions to simplify the implementation of the new get_logs
tool by removing some redundant validation logic, which will improve maintainability.
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new MCP tool for fetching Cloud Functions logs and refactors the listEntries
API to support pagination. The changes are well-organized, adding new tools, formatters, and error handlers for the functions feature. The refactoring of listEntries
is consistently applied throughout the codebase. I've identified a couple of areas in the new log formatting logic where payload extraction could be more robust to handle all possible data types correctly. My specific comments include suggestions to address these points.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty much LGTM with minor fixes. Can you also throw up a screenshot/video of Gemini using this tool as a sanity check?
Includes small refactor in the existing API to fetch logs from Cloud Logging to support pagination.