-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[VS Code] Always show "Generate Operation" code lens #9233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @fredzqm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the user experience for the Firebase VS Code extension's Data Connect features by making the "Generate Operation" code lens consistently visible. This change allows users to see the available action earlier, while robustly handling the requirement for a connected Firebase project by adding a runtime check and informative error message when the operation is actually triggered. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly modifies the behavior to always show the 'Generate Operation' code lens, moving the project existence check into the command handler. The changes are logical and well-implemented. I've included one suggestion to improve code readability by using a more modern loop construct.
for (let i = 0; i < comments.length; i++) { | ||
const c = comments[i]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hlshen Here is a very small incremental improvement. This can improve discoverability of this code lens even if the developer started without a project. |
Even when project isn't present, show the "Generate Operation" code lens. Always error out suggesting connecting a Firebase Project.