-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add common appUtils to augment get_environment with app level data #9236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
e951142
to
d75b0a7
Compare
0c515ca
to
a5bece4
Compare
platform: Platform; | ||
directory: string; | ||
appId?: string; | ||
bundleId?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can there ever be a case where an app directory found >1 appId
/ bundleId
?
If the underlying detectAppIdsForPlatform
could potentially return multiple? Maybe it's safer to include all responses in the App
struct.
We can log those anomaly at a higher level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can and does happen. In this case, I create multiple app instances. They are unique by appId and bundleId but may have the same platform and directory.
2ea682b
to
2add8f1
Compare
@@ -0,0 +1,314 @@ | |||
import * as fs from "fs-extra"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file seems to duplicate a lot of what we've built in https://github.com/firebase/firebase-tools/blob/master/src/dataconnect/appFinder.ts - we really ought to unify the 2. I recall @fredzqm was looking at doing something like this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have followup PR to do just that. I had some of that in here, but Fred recommended I take it out. See the conversation here: #9236 (comment)
Description
Scenarios Tested
Sample Commands