Changelog for MCP changes and latest FDC emulator #9244
Conversation
Summary of ChangesHello @joehan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds several changelog entries for recent MCP and Data Connect updates. The new entries are informative, but I've found a couple of minor issues. There's a typo in one entry and another could be rephrased for better clarity and consistency with the rest of the changelog. I've provided suggestions to correct these.
| @@ -1,5 +1,10 @@ | |||
| - Fixed an issue with deploying indexes to Firestore Enterprise edition databases where explicit `__name__` fields could be incorrectly handled. | |||
| - The `experimental:mcp` command has been renamed to `mcp`. The old name is now an alias. | |||
| - Graduated the MCP server from experiemental, and renamed the `experimental:mcp` command to `mcp`. The old name is now an alias. | |||
There was a problem hiding this comment.
There's a typo in 'experiemental'. It should be 'experimental'.
| - Graduated the MCP server from experiemental, and renamed the `experimental:mcp` command to `mcp`. The old name is now an alias. | |
| - Graduated the MCP server from experimental, and renamed the `experimental:mcp` command to `mcp`. The old name is now an alias. |
| - Fixed an issue where deploying multiple Hosting sites with Functions could encounter a race condition (#9235). | ||
| - Updated the Data Connect local dev toolkit to 2.14.0, which includes the following changes: | ||
| - Fixed a bug where @default(value) and @default(expr) is not validated on enum fields. | ||
| - JS/Kotlin codegen: Issue where if no response type was generated, generation would crash. |
There was a problem hiding this comment.
This changelog entry is a bit vague. For consistency and clarity with other entries in this file, consider rephrasing it to start with 'Fixed an issue where...'. This makes it clearer to the reader what was resolved.
| - JS/Kotlin codegen: Issue where if no response type was generated, generation would crash. | |
| - JS/Kotlin codegen: Fixed an issue where generation would crash if no response type was generated. |
Description
Adding some missing changelog entries.