Skip to content

Hosting Functional Test; OAuth Scopes Fix #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Nov 5, 2018
Merged

Hosting Functional Test; OAuth Scopes Fix #998

merged 15 commits into from
Nov 5, 2018

Conversation

bkendall
Copy link
Contributor

@bkendall bkendall commented Nov 5, 2018

Description

This is doing two things:

  • Creates a functional test for hosting that uses GOOGLE_APPLICATION_CREDENTIALS for authentication
  • Fixes authentication using GOOGLE_APPLICATION_CREDENTIALS - no auth scopes were being provided, but that is now fixed.

Scenarios Tested

Firebase deploy with hosting and functions and database features.

And hosting via Travis!

@bkendall bkendall requested a review from mbleigh November 5, 2018 19:57
@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label Nov 5, 2018
@coveralls
Copy link

coveralls commented Nov 5, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 56.491% when pulling 5ba5231 on bk-hosting-test into eee904b on master.

@bkendall bkendall merged commit 645483a into master Nov 5, 2018
@bkendall bkendall deleted the bk-hosting-test branch November 5, 2018 23:16
@bkendall bkendall mentioned this pull request Nov 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbleigh mbleigh mbleigh approved these changes

Assignees

@mbleigh mbleigh

Labels

cla: yes Manual indication that this has passed CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bkendall @coveralls @mbleigh @googlebot