Skip to content

[FirebaseAI] Shorten namespace to Firebase.AI #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

a-maurice
Copy link
Collaborator

Description

Provide details of the change, and generalize the change in the PR title above.

Changing the namespace from Firebase.FirebaseAI to Firebase.AI. The longer one was causing confusion with the class FirebaseAI, and general C# advice is to try to avoid that type of conflict.


Testing

Describe how you've tested these changes.

Running tests locally


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request focuses on renaming the namespace Firebase.FirebaseAI to Firebase.AI throughout the codebase. This change is intended to avoid confusion with the class FirebaseAI and aligns with general C# naming conventions. The changes affect multiple files, primarily updating namespace declarations and references within the Firebase AI SDK.

Highlights

  • Namespace change: The primary change is the renaming of the namespace from Firebase.FirebaseAI to Firebase.AI.
  • Code consistency: All files within the Firebase AI SDK have been updated to reflect the new namespace.
  • Internal namespace: The internal namespace Firebase.FirebaseAI.Internal has been updated to Firebase.AI.Internal.

Changelog

Click here to see the changelog
  • firebaseai/src/Candidate.cs
    • Updated namespace from Firebase.FirebaseAI to Firebase.AI on line 23.
    • Updated FinishReason references from Firebase.FirebaseAI.FinishReason to Firebase.AI.FinishReason on lines 111, 112, 113, 114, 115, 116, 117, 118, 119, 120.
    • Updated CitationMetadata references from Firebase.FirebaseAI.CitationMetadata to Firebase.AI.CitationMetadata on line 135.
  • firebaseai/src/Chat.cs
    • Updated namespace from Firebase.FirebaseAI to Firebase.AI on line 25.
  • firebaseai/src/Citation.cs
    • Updated namespace from Firebase.FirebaseAI to Firebase.AI on line 22.
  • firebaseai/src/CountTokensResponse.cs
    • Updated namespace from Firebase.FirebaseAI to Firebase.AI on line 22.
  • firebaseai/src/FirebaseAI.cs
    • Updated namespace from Firebase.FirebaseAI to Firebase.AI on line 20.
  • firebaseai/src/FirebaseAIException.cs
    • Updated namespace from Firebase.FirebaseAI to Firebase.AI on line 20.
  • firebaseai/src/FunctionCalling.cs
    • Updated namespace from Firebase.FirebaseAI to Firebase.AI on line 22.
  • firebaseai/src/GenerateContentResponse.cs
    • Updated namespace from Firebase.FirebaseAI to Firebase.AI on line 23.
    • Updated PromptFeedback references from Firebase.FirebaseAI.PromptFeedback to Firebase.AI.PromptFeedback on line 95.
    • Updated UsageMetadata references from Firebase.FirebaseAI.UsageMetadata to Firebase.AI.UsageMetadata on line 97.
    • Updated BlockReason references from Firebase.FirebaseAI.BlockReason to Firebase.AI.BlockReason on lines 157, 158, 159, 160, 161.
  • firebaseai/src/GenerationConfig.cs
    • Updated namespace from Firebase.FirebaseAI to Firebase.AI on line 22.
  • firebaseai/src/GenerativeModel.cs
    • Updated namespace from Firebase.FirebaseAI to Firebase.AI on line 29.
  • firebaseai/src/Internal/EnumConverters.cs
    • Updated namespace from Firebase.FirebaseAI.Internal to Firebase.AI.Internal on line 17.
  • firebaseai/src/Internal/FirebaseInterops.cs
    • Updated namespace from Firebase.FirebaseAI.Internal to Firebase.AI.Internal on line 23.
  • firebaseai/src/Internal/InternalHelpers.cs
    • Updated namespace from Firebase.FirebaseAI.Internal to Firebase.AI.Internal on line 21.
  • firebaseai/src/LiveGenerationConfig.cs
    • Updated namespace from Firebase.FirebaseAI to Firebase.AI on line 21.
  • firebaseai/src/LiveGenerativeModel.cs
    • Updated namespace from Firebase.FirebaseAI to Firebase.AI on line 27.
  • firebaseai/src/LiveSession.cs
    • Updated namespace from Firebase.FirebaseAI to Firebase.AI on line 27.
  • firebaseai/src/LiveSessionResponse.cs
    • Updated namespace from Firebase.FirebaseAI to Firebase.AI on line 25.
  • firebaseai/src/ModalityTokenCount.cs
    • Updated namespace from Firebase.FirebaseAI to Firebase.AI on line 20.
  • firebaseai/src/ModelContent.cs
    • Updated namespace from Firebase.FirebaseAI to Firebase.AI on line 23.
  • firebaseai/src/RequestOptions.cs
    • Updated namespace from Firebase.FirebaseAI to Firebase.AI on line 19.
  • firebaseai/src/ResponseModality.cs
    • Updated namespace from Firebase.FirebaseAI to Firebase.AI on line 17.
  • firebaseai/src/Safety.cs
    • Updated namespace from Firebase.FirebaseAI to Firebase.AI on line 21.
  • firebaseai/src/Schema.cs
    • Updated namespace from Firebase.FirebaseAI to Firebase.AI on line 22.
  • firebaseai/testapp/Assets/Firebase/Sample/FirebaseAI/UIHandlerAutomated.cs
    • Updated namespace from Firebase.FirebaseAI to Firebase.AI on line 21.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A namespace refined,
Clarity in code we find,
Firebase's AI.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request changes the namespace from Firebase.FirebaseAI to Firebase.AI. This seems like a reasonable change to avoid confusion between the namespace and the class FirebaseAI. The code changes look straightforward and consistent.

Merge Readiness

The pull request appears to be well-structured and addresses a valid concern regarding namespace clarity. I am unable to directly approve the pull request, and users should have others review and approve this code before merging. Given the nature of the changes and the local testing performed by the author, the pull request seems ready for merging.

@a-maurice a-maurice merged commit 0fb0f9e into main May 7, 2025
5 checks passed
@a-maurice a-maurice deleted the am-firebaseai_namespace branch May 7, 2025 22:58
@firebase firebase locked and limited conversation to collaborators Jun 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants