-
Notifications
You must be signed in to change notification settings - Fork 49
[Firebase AI] Add support for URL Context #1340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Firebase AI SDK by introducing support for the URL Context tool. This new feature allows generative AI models to browse and incorporate information from specified public web URLs directly into their responses, providing richer and more contextually relevant outputs. The changes involve extending core data models like "Candidate" and "UsageMetadata" to accommodate URL-specific information and token tracking, alongside the creation of new types to manage URL retrieval details. Comprehensive automated tests have been added to ensure the reliability of this new capability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for the URL Context tool in Firebase AI, allowing the model to fetch data from provided URLs. The changes include adding new data structures for URL context metadata, integrating it into the Tool
and Candidate
types, and updating UsageMetadata
to account for tool usage tokens. New tests have been added to cover this functionality. The implementation is solid, but I have a few suggestions to improve type safety and code clarity.
firebaseai/testapp/Assets/Firebase/Sample/FirebaseAI/UIHandlerAutomated.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessary for this PR, and also not sure this will be a breaking change. This file/class starting to more of Tool instead of FunctionCalling, so we might want to looking into rename/refactor sometime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, because it is a source library now, changing that is a bit complicated...
Description
Add support for the URL Context tool, which lets the model fetch data from given URLs.
Testing
Running tests locally.
Type of Change
Place an
x
the applicable box: