-
Notifications
You must be signed in to change notification settings - Fork 49
[Firebase AI] Add new send realtime data functions #1349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Firebase AI LiveSession by introducing dedicated asynchronous functions for sending specific types of realtime data: text, audio, and video. This change deprecates the previous generic SendMediaChunksAsync method, providing a more granular and explicit API for developers, which also aligns with recent backend updates. The update improves the clarity and usability of the realtime data streaming capabilities. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces new, more specific methods for sending realtime data (SendTextRealtimeAsync
, SendAudioRealtimeAsync
, SendVideoRealtimeAsync
) and deprecates the older SendMediaChunksAsync
method. This is a great improvement for API clarity and aligns with backend changes. The refactoring to use a common internal method InternalSendRealtimeInputAsync
is also a positive change that reduces code duplication. My review includes suggestions to improve robustness by adding null checks to the new methods and to clean up the XML documentation for consistency and correctness.
Description
Add SendTextRealtimeAsync, SendAudioRealtimeAsync, and SendVideoRealtimeAsync to the LiveSession, to provide more specific functions for sending data to the backend. Deprecate the prior SendMediaChunksAsync, since that is now deprecated on the backend.
Testing
Running tests locally.
Type of Change
Place an
x
the applicable box: