Skip to content

Update the Unity versions being used #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 18, 2022
Merged

Update the Unity versions being used #296

merged 4 commits into from
May 18, 2022

Conversation

a-maurice
Copy link
Collaborator

Description

Provide details of the change, and generalize the change in the PR title above.

u3d recently released a new version that is causing problems with our use case. Until we can fix it, pin to the previously released version.


Testing

Describe how you've tested these changes.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@a-maurice a-maurice requested a review from sunmou99 May 17, 2022 18:46
sunmou99
sunmou99 previously approved these changes May 17, 2022
Copy link
Contributor

@sunmou99 sunmou99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is the optional solution for now.
Because as you mentioned:

  1. new version of u3d has a issue: DragonBox/u3d#421
  2. older version of u3d requires us to use a newer version: https://github.com/firebase/firebase-unity-sdk/runs/6476560371?check_suite_focus=true#step:9:2206

@a-maurice a-maurice changed the title Pin the u3d version to 1.2.3 Update the Unity versions being used May 17, 2022
@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label May 17, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 17, 2022
@github-actions
Copy link

github-actions bot commented May 17, 2022

❌  Integration test FAILED

Requested by @a-maurice on commit e9f597b
Last updated: Wed May 18 14:28 PDT 2022
View integration test log & download artifacts

Failures Configs
firestore [TEST] [ERROR] [2019] [macos] [1/5 Platform(s): Android] [1/2 Test Device(s): android_target]
[TEST] [FAILURE] [2019] [macos] [2/5 Platform(s): Android ubuntu] [1/2 Test Device(s): android_target]
[TEST] [FLAKINESS] [2019] [macos] [1/5 Platform(s): iOS] [1/2 Test Device(s): ios_target]
messaging [TEST] [ERROR] [2019] [macos] [2/5 Platform(s): Android iOS] [All 2 Test Device(s)]
storage [BUILD] [ERROR] [2019] [macos] [All 3 Platform(s)]

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 17, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 17, 2022
@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label May 17, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels May 17, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 18, 2022
@a-maurice a-maurice requested a review from sunmou99 May 18, 2022 17:53
Copy link
Contributor

@sunmou99 sunmou99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-maurice a-maurice merged commit e9f597b into main May 18, 2022
@a-maurice a-maurice deleted the am-u3d_problem branch May 18, 2022 17:56
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: failed This PR's integration tests failed. labels May 18, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 18, 2022
@firebase firebase locked and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants