Skip to content

Make build_ios pass empty sysroot when building device and simulator #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 18, 2022
Merged

Make build_ios pass empty sysroot when building device and simulator #299

merged 2 commits into from
May 18, 2022

Conversation

a-maurice
Copy link
Collaborator

Description

Provide details of the change, and generalize the change in the PR title above.

The CMAKE_OSX_SYSROOT needs to be empty to handle device and simulator together.

Testing

Describe how you've tested these changes.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

cynthiajoan
cynthiajoan previously approved these changes May 18, 2022
View reviewed changes
@a-maurice a-maurice merged commit d25407c into main May 18, 2022
@a-maurice a-maurice deleted the am-build_ios_fix branch May 18, 2022 21:56
@firebase firebase locked and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cynthiajoan cynthiajoan cynthiajoan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-maurice @cynthiajoan